Re: [PATCH] remote-curl: ensure that URLs do not have a trailing slash
Hi,
On Wed, Apr 7, 2010 at 11:12 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 8 quoted lines
> The code does not look like it is making sure things do not have a
> trailing slash. For example, if svc has trailing slash, either %s/%s or
> strbuf_addf() would have the last character of svc in rpc->service_url.
>
> You are fixing something else.
>
> The new code avoids duplicated slashes in the middle if "url" can but does
> not necessarily end with a slash. Is that what you are trying to fix?
the commit message is misleading, yes. I'll have another go at it.
> I
> wonder if it makes more sense to make sure "url" always ends with a slash
> at the calling sites where it is obtained from either the end user or from
> the running environment...
--
Cheers,
Ray Chuan
Tay Ray Chuan <rctay89@gmail.com>