From: Tay Ray Chuan Date: Wed, 07 Apr 2010 15:57:28 GMT Subject: Re: [PATCH] remote-curl: ensure that URLs do not have a trailing slash Message-ID: In-Reply-To: <7viq83e1pd.fsf@alter.siamese.dyndns.org> Hi, On Wed, Apr 7, 2010 at 11:12 PM, Junio C Hamano wrote: > The code does not look like it is making sure things do not have a > trailing slash.  For example, if svc has trailing slash, either %s/%s or > strbuf_addf() would have the last character of svc in rpc->service_url. > > You are fixing something else. > > The new code avoids duplicated slashes in the middle if "url" can but does > not necessarily end with a slash.  Is that what you are trying to fix? the commit message is misleading, yes. I'll have another go at it. >  I > wonder if it makes more sense to make sure "url" always ends with a slash > at the calling sites where it is obtained from either the end user or from > the running environment... Good idea. -- Cheers, Ray Chuan