Re: git cvsimport and case-insensitive config

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Mar 31, 2010, 11:17 UTC
Message-ID: <p2mcb7bb73a1003310417u3821f8b1hd3df79e8b41502c3@mail.gmail.com>
In-Reply-To: <7v634cq0yj.fsf@alter.siamese.dyndns.org>

On Wed, Mar 31, 2010 at 11:45 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
>
>> What I wonder is: when would the heuristics not work? Are there git
>> repositories that have a cvsimport configuration with both -s and -S
>> specified?
>
> You are asking a wrong question.  Setting both -s and -S is not an issue.
> Not being able to tell reliably if the value you see for cvsimport.s in
> "config -l" output were specified for cvsimport.S or cvsimport.s is only
> by inspecting the value is.

What I'm asking is rahter: is it worth to worry about this?

Show 14 quoted lines

>> I strongly suspect the answer is NO because such a
>> configuration would not work currently (at least not reliably as the
>> wrong value would be assigned to at least one of the keys.
>
> So this is a moot point, but people who specified cvsimport.S expecting
> that it would stand for -S option are not getting what they want and are
> getting -s instead, which is also a case where the configuration is not
> working currently.
>
> Silently converting it to an equally non-working configuration is easy;
> just treat as if everything were specified for lowercase option.
>
> But that would not help users at all.  I was hoping that you were aiming
> for something better than that.  At least that "case-sensitive" patch was.

Well, I wasn't thinking about a silent conversion for the uncertain options: in the case of dubious options which we can guess (a vs A, r vs R), a warning would be given, and for the unguessable case we could either still give a warning and continue or even abort the process altogether. Better than the silent conversion (which would not break anything that isn't broken already anyway), although probably not as sophisticated as your proposal.

-- 
Giuseppe "Oblomov" Bilotta