Re: git cvsimport and case-insensitive config
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 31, 2010, 09:45 UTC
- Message-ID
- <7v634cq0yj.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <y2kcb7bb73a1003302354wea191dd4iced4360b95d31a2a@mail.gmail.com>
Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
> What I wonder is: when would the heuristics not work? Are there git > repositories that have a cvsimport configuration with both -s and -S > specified?
You are asking a wrong question. Setting both -s and -S is not an issue. Not being able to tell reliably if the value you see for cvsimport.s in "config -l" output were specified for cvsimport.S or cvsimport.s is only by inspecting the value is.
> I strongly suspect the answer is NO because such a > configuration would not work currently (at least not reliably as the > wrong value would be assigned to at least one of the keys.
So this is a moot point, but people who specified cvsimport.S expecting that it would stand for -S option are not getting what they want and are getting -s instead, which is also a case where the configuration is not working currently.
Silently converting it to an equally non-working configuration is easy; just treat as if everything were specified for lowercase option.
But that would not help users at all. I was hoping that you were aiming for something better than that. At least that "case-sensitive" patch was.