Re: [PATCH] Documentation/config.txt: Move GIT_NOTES_REWRITE_REF to notes.rewriteRef

From: Leif Arne Storset <lstorset@opera.com>
Date: May 5, 2010, 14:15 UTC
Message-ID: <op.vb8kjmmktmo5g6@nynorsk>
In-Reply-To: <201005051600.03446.trast@student.ethz.ch>

Thomas Rast <trast@student.ethz.ch> skreiv Wed, 05 May 2010 16:00:03 +0200

Show 13 quoted lines

> Leif Arne Storset wrote:
>> Was notes.rewrite. The environment variable refers to globs and refs,  
>> which are only mentioned by notes.rewriteRef; notes.rewrite is boolean.
>>
>> Signed-off-by: Leif Arne Storset <lstorset@opera.com>
>> ---
>> This should be a trivial fix.
>
> ACK and thanks for spotting this.  Putting it in the wrong place was
> my fault.
>
> I found the commit message confusing, though (my first thought was "we
> have a notes.rewrite configuration variable?"), and you also have a

Yeah, I misread it as notes.rewrite.

Show 8 quoted lines

> way too long line there.  How about
>
>   Documentation/config.txt: GIT_NOTES_REWRITE_REF overrides  
> notes.rewriteRef
>
>   The documentation erroneously mentions the GIT_NOTES_REWRITE_REF
>   override in the description of notes.rewrite.<command>.  Move it
>   under notes.rewriteRef where it belongs.

Thanks, looks good. I suppose I should file a PATCH v2 now, it'll be along in a minute.

-- 
Leif Arne Storset
Core Technology Developer, Opera Software
Oslo, Norway