Re: [PATCH] Documentation/config.txt: Move GIT_NOTES_REWRITE_REF to notes.rewriteRef

From: Thomas Rast <trast@student.ethz.ch>
Date: May 5, 2010, 14:00 UTC
Message-ID: <201005051600.03446.trast@student.ethz.ch>
In-Reply-To: <1273066516-24469-1-git-send-email-lstorset@opera.com>

Leif Arne Storset wrote:

Show 5 quoted lines

> Was notes.rewrite. The environment variable refers to globs and refs, which are only mentioned by notes.rewriteRef; notes.rewrite is boolean.
> 
> Signed-off-by: Leif Arne Storset <lstorset@opera.com>
> ---
> This should be a trivial fix.

ACK and thanks for spotting this. Putting it in the wrong place was my fault.

I found the commit message confusing, though (my first thought was "we have a notes.rewrite configuration variable?"), and you also have a way too long line there. How about

  Documentation/config.txt: GIT_NOTES_REWRITE_REF overrides notes.rewriteRef

  The documentation erroneously mentions the GIT_NOTES_REWRITE_REF
  override in the description of notes.rewrite.<command>.  Move it
  under notes.rewriteRef where it belongs.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch