js/use-builtin-add-i, was Re: What's cooking in git.git (May 2022, #06; Fri, 20)
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- May 21, 2022, 22:02 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2205212352540.352@tvgsbejvaqbjf.bet>
- In-Reply-To
- <xmqqmtfbcoaa.fsf@gitster.g>
Hi Junio,
On Sat, 21 May 2022, Junio C Hamano wrote:
Show 15 quoted lines
> * js/use-builtin-add-i (2021-12-01) 2 commits > - add -i: default to the built-in implementation > - t2016: require the PERL prereq only when necessary > > "git add -i" was rewritten in C some time ago and has been in > testing; the reimplementation is now exposed to general public by > default. > > On hold. > > What's the status of the "known breakage"? > Are we ready to switch if we wanted to? > There are known breakages on macOS. > cf. <nycvar.QRO.7.76.6.2112021832060.63@tvgsbejvaqbjf.bet> > source: <pull.1087.git.1638281655.gitgitgadget@gmail.com>
As per https://lore.kernel.org/git/CAPUEspg1cJC_UwjJFx-jnzWsascY++S3UgM1UCLRcnK_Mv2wOg@mail.gmail.com/, I believe that the macOS breakages have been confirmed to be addressed by `pw/single-key-interactive` (which was merged in 32f3ac26e03, i.e. it was included in v2.36.0).
Therefore, right now might be a good time to advance the `js/use-builtin-add-i` series.
Thanks, Dscho