ds/bundle-uri (was Re: What's cooking in git.git (May 2022, #06; Fri, 20))

From: Derrick Stolee <derrickstolee@github.com>
Date: May 21, 2022, 18:07 UTC
Message-ID: <a467d972-85a6-f4b0-7ec7-184add308e25@github.com>
In-Reply-To: <xmqqmtfbcoaa.fsf@gitster.g>

On 5/21/22 3:55 AM, Junio C Hamano wrote:

Show 25 quoted lines

> * ds/bundle-uri (2022-05-20) 32 commits
>  - t5601: basic bundle URI tests
>  - clone: unbundle the advertised bundles
>  - bundle-uri: download bundles from an advertised list
>  - bundle-uri: allow relative URLs in bundle lists
>  - bundle-uri client: add boolean transfer.bundleURI setting
>  - bundle-uri: serve URI advertisement from bundle.* config
>  - bundle-uri client: add "git ls-remote-bundle-uri"
>  - bundle-uri client: add minimal NOOP client
>  - protocol v2: add server-side "bundle-uri" skeleton
>  - bundle-uri: fetch a list of bundles
>  - bundle-uri: parse bundle list in config format
>  - bundle-uri: limit recursion depth for bundle lists
>  - bundle-uri: unit test "key=value" parsing
>  - bundle-uri: create "key=value" line parsing
>  - bundle-uri: create base key-value pair parsing
>  - bundle-uri: create bundle_list struct and helpers
>  - clone: --bundle-uri cannot be combined with --depth
>  - clone: add --bundle-uri option
>  - fetch: add 'refs/bundle/' to log.excludeDecoration
>  - fetch: add --bundle-uri option
>  - bundle-uri: add support for http(s):// and file://
>  - bundle-uri: create basic file-copy logic
>  - remote-curl: add 'get' capability
>  - docs: document bundle URI standard

...

>  source: <pull.1234.git.1653072042.gitgitgadget@gmail.com>

These patches are for the combined bundle URI RFC. I appreciate that you're tracking them, but they aren't ready for full review, since they are missing a lot of tests. First, we need to establish that the overall design is a good approach. After that consensus is reached, I expect that this series to be split into several parts that are more manageable to review bit-by-bit.

Show 10 quoted lines

>  - bundle.h: make "fd" version of read_bundle_header() public
>  - remote: allow relative_url() to return an absolute url
>  - remote: move relative_url()
>  - http: make http_get_file() external
>  - fetch-pack: move --keep=* option filling to a function
>  - fetch-pack: add a deref_without_lazy_fetch_extended()
>  - dir API: add a generalized path_match_flags() function
>  - connect.c: refactor sending of agent & object-format
> 
>  source: <pull.1233.git.1652731865.gitgitgadget@gmail.com>

While these are for the patches leading up to it, which are ready for review.

I think the two should be tracked independently.

Thanks, -Stolee