Re: [PATCH v3 08/15] merge-ort: allow update messages to be written to different file stream
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 21, 2022, 09:13 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2202211011510.26495@tvgsbejvaqbjf.bet>
- In-Reply-To
- <CABPp-BFFcFxWL+FRSf9ANwHU1mp_oWcsfLOwvBAuv-J3oNh3SA@mail.gmail.com>
Hi Elijah,
On Thu, 3 Feb 2022, Elijah Newren wrote:
Show 17 quoted lines
> On Thu, Feb 3, 2022 at 8:24 AM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote: > > > > On Thu, Feb 03 2022, Elijah Newren wrote: > > > > > Man, what a can of worms this all is. Maybe I really should just drop > > > patches 5, 6, and 8 for now... > > > > Yeah, I really think it's worth it to just sprinkle a tiny bit of > > if/else (or a macro) here and print to stderr inline or not. We can make > > some use of some usage.c when there's good reason to do so, but this bit > > just seems like a needless digression. > > > > I hope all of this has helped somewhat ... > > Absolutely; thanks for reviewing! These parts may just end up in me > dropping some patches for now (since they're not actually being used > anyway), but I think it's all good feedback.
So we dropped some useful patches future-proofing `merge-tree` for the sake of appeasing a refactoring with no immediately obvious benefit? I really don't like that direction.
Ciao, Dscho