Re: [PATCH 0/1] xdiff: share xdiff between git and libgit2

From

Johannes Schindelin <johannes.schindelin@gmx.de>

Date

Feb 17, 2022, 15:44 UTC

Message-ID

<nycvar.QRO.7.76.6.2202171644090.348@tvgsbejvaqbjf.bet>

In-Reply-To

<20220209012951.GA7@abe733c6e288>

Hi Ed,

On Wed, 9 Feb 2022, Edward Thomson wrote:

> Hello from libgit2, where we borrowed your xdiff a few years ago and
> have watched as we both hacked on it independently.  (For us, mostly it
> was around tightening some things up around warnings and signed/unsigned
> mismatches.)  However, we'd love to share a common xdiff implementation,
> and we're happy if git is the home for that.

Great!

> The next patch adds an indirection point, `git-xdiff.h`, that contains
> the git-specific functionality in xdiff.  This keeps the core of xdiff
> to standard functions.  Other xdiff users, like libgit2, can specify
> their own compatibility functions in this header file.

I like this direction and looked over the patch: ACK!

> I hope that this allows us to make progress on a common xdiff; we'd love
> to go back to building it without warnings, but we'd like to not do that
> in isolation.

Yes, let's combine efforts.