git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Makefile: fix parallel build race

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Nov 19, 2021, 15:44 UTC
Message-ID
<nycvar.QRO.7.76.6.2111191625002.63@tvgsbejvaqbjf.bet>
In-Reply-To
<211119.86ilwo4o8c.gmgdl@evledraar.gmail.com>
Hi Ævar,
On Fri, 19 Nov 2021, Ævar Arnfjörð Bjarmason wrote:
> I think getting it working on non-Windows if we're going to keep it
> (which looks to be the case) would be very useful.

The idea to extend the CMake to more than just Windows is contrary to what Junio said in https://lore.kernel.org/git/xmqq1rmcm6md.fsf@gitster.c.googlers.com/:

	Let's not worry about cross-platform and instead stick to Windows
	and nothing else for now to expedite the process.  As long as it
	is advertised as such, nobody would complain that it does not work
	on Linux or macOS.

If that is not enough to tone down opposing opinions (the opinion of the Git maintainer is more important, after all, it's his maintenance burden so he gets to decide), you can also look at this statement from https://lore.kernel.org/git/xmqq8sikblv2.fsf@gitster.c.googlers.com/:

	I already said that I feel that engineering burden to divert
	resources for CMake support would be unacceptably high.

The only reason we have CMake in addition to the Makefile (and the autoconf-based) setup is that CMake makes it possible to build Git on Windows in the development environment with which the majority of the developers on Windows are familiar: Visual Studio.

If it weren't for those developers, for who it would be a ridiculous suggestion to "just go download GNU make", we would not have the CMake based build at all.

And I am still agreeing with what Junio further said in the second mail I linked above:

	[...] it is unclear why it would be beneficial to slow our
	existing developers down by forcing them to become familiar with
	CMake.

So now we are discussing to extend the CMake build to allow Linux and macOS developers to use it, to, for little to no benefit. We are very much in the situation where we are slowed down by discussing something as non-essential as extending our CMake support beyond Windows, while patches that are provably much more beneficial to a lot more people are left under-reviewed.

Even worse: reviewers who _could_ provide high-quality reviews for those patches (which takes a lot of time and diligence), but are as much pressed for time as I am and therefore have to choose wisely how to spend their time, are _actively_ distracted from spending their time more wisely.

Can't we please focus on more relevant things again? Pretty please?

Ciao, Johannes

Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 11 of 12 in “Makefile: fix parallel build race”
  1. Makefile: fix parallel build raceĐoàn Trần Công Danh, Nov 17, 2021
  2. Jeff KingNov 17, 2021
  3. Mike HommeyNov 17, 2021
  4. Ævar Arnfjörð BjarmasonNov 17, 2021
  5. Johannes SchindelinNov 17, 2021
  6. Ævar Arnfjörð BjarmasonNov 17, 2021
  7. Đoàn Trần Công DanhNov 18, 2021
  8. Johannes SchindelinNov 18, 2021
  9. Ævar Arnfjörð BjarmasonNov 19, 2021
  10. Ævar Arnfjörð BjarmasonNov 19, 2021
  11. Johannes SchindelinNov 19, 2021
  12. Ævar Arnfjörð BjarmasonNov 19, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.