Re: [PATCH] Makefile: fix parallel build race

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 17, 2021, 23:14 UTC
Message-ID: <nycvar.QRO.7.76.6.2111180012470.21127@tvgsbejvaqbjf.bet>
In-Reply-To: <YZR0djZbRUicXcQm@coredump.intra.peff.net>

Hi Peff,

On Tue, 16 Nov 2021, Jeff King wrote:

> I wondered if contrib/buildsystems/CMakeLists would need a similar
> fixup, but it doesn't have any generated header dependencies at all (not
> for hook-list.h, but not for the existing command-list.h). So I'll
> assume it's fine (as did cfe853e66b).

The strategy we take in our CMake-based configuration is for files like hook-list.h to be generated at _configure_ time, i.e. before the build definition file is written, i.e. well before the build. That's why there is no explicit dependency, it's not necessary.

Ciao, Dscho