Re: [PATCH 2/2] prompt.c: add and use a GIT_TEST_TERMINAL_PROMPT=true

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 4, 2021, 08:48 UTC
Message-ID: <nycvar.QRO.7.76.6.2111040945280.56@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqo8716sqx.fsf@gitster.g>

Hi Junio & Peff,

On Wed, 3 Nov 2021, Junio C Hamano wrote:

Show 9 quoted lines

> Jeff King <peff@peff.net> writes:
>
> > Basically, I think I just disagree with this paragraph entirely.
> > Moving to stdin in the commits you referenced was done to help
> > testing, but I also think it's just a more flexible direction overall.
>
> It is OK, and it is more convenient for writing test scripts, to take
> interactive input from the standard input stream, if the command does
> not use the standard input for other purposes.

I think I remember when we talked about this, it was in the context of `git add -p` becoming a built-in, and we all agreed that it is actually a very nice side effect that you can feed commands to `git add -p` in scripts via stdin, not only for testing.

It might have been in the context of another command, but even then it is a fact that this is a very nice side effect.

Ciao, Dscho