git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] prompt.c: add and use a GIT_TEST_TERMINAL_PROMPT=true

From
Jeff King <peff@peff.net>
Date
Nov 4, 2021, 09:47 UTC
Message-ID
<YYOsHkMgUa7CXLic@coredump.intra.peff.net>
In-Reply-To
<nycvar.QRO.7.76.6.2111040945280.56@tvgsbejvaqbjf.bet>
On Thu, Nov 04, 2021 at 09:48:35AM +0100, Johannes Schindelin wrote:
Show 21 quoted lines
> Hi Junio & Peff,
> 
> On Wed, 3 Nov 2021, Junio C Hamano wrote:
> 
> > Jeff King <peff@peff.net> writes:
> >
> > > Basically, I think I just disagree with this paragraph entirely.
> > > Moving to stdin in the commits you referenced was done to help
> > > testing, but I also think it's just a more flexible direction overall.
> >
> > It is OK, and it is more convenient for writing test scripts, to take
> > interactive input from the standard input stream, if the command does
> > not use the standard input for other purposes.
> 
> I think I remember when we talked about this, it was in the context of
> `git add -p` becoming a built-in, and we all agreed that it is actually a
> very nice side effect that you can feed commands to `git add -p` in
> scripts via stdin, not only for testing.
> 
> It might have been in the context of another command, but even then it is
> a fact that this is a very nice side effect.

Yes, we definitely had that discussion about "add -p", and I agree it is nice. People are probably less likely to drive other tools like git-am and git-bisect in such a way, though, as their interactive modes just do a lot less.

-Peff
Previous: Johannes SchindelinNext: Jeff King
Message 20 of 30 in “Abort (core dumped)”
  1. Alejandro SanchezMay 20, 2019
  2. Jeff KingMay 20, 2019
  3. 0/4 fix BUG() with "git am -i --resolved"Jeff King, May 20, 2019
  4. 1/4 am: simplify prompt response handlingJeff King, May 20, 2019
  5. 2/4 am: read interactive input from stdinJeff King, May 20, 2019
  6. 3/4 am: drop tty requirement for --interactiveJeff King, May 20, 2019
  7. Jeff KingMay 20, 2019
  8. Johannes SchindelinMay 23, 2019
  9. Jeff KingMay 24, 2019
  10. 0/2 prompt.c: split up git_prompt(), read from /dev/tty, not STDINÆvar Arnfjörð Bjarmason, Nov 2, 2021
  11. 1/2 prompt.c: split up the password and non-password handlingÆvar Arnfjörð Bjarmason, Nov 2, 2021
  12. Jeff KingNov 3, 2021
  13. Junio C HamanoNov 3, 2021
  14. 2/2 prompt.c: add and use a GIT_TEST_TERMINAL_PROMPT=trueÆvar Arnfjörð Bjarmason, Nov 2, 2021
  15. Jeff KingNov 3, 2021
  16. Ævar Arnfjörð BjarmasonNov 3, 2021
  17. Jeff KingNov 4, 2021
  18. Junio C HamanoNov 3, 2021
  19. Johannes SchindelinNov 4, 2021
  20. Jeff KingNov 4, 2021
  21. Jeff KingNov 4, 2021
  22. 4/4 am: fix --interactive HEAD tree resolutionJeff King, May 20, 2019
  23. Johannes SchindelinMay 23, 2019
  24. Jeff KingMay 24, 2019
  25. 4/4 am: fix --interactive HEAD tree resolutionJeff King, May 24, 2019
  26. Johannes SchindelinMay 28, 2019
  27. Jeff KingMay 28, 2019
  28. Johannes SchindelinMay 29, 2019
  29. Alejandro SanchezSep 26, 2019
  30. Jeff KingSep 26, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.