Re: [PATCH 4/5] rebase -i: don't fork git checkout
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Sep 9, 2021, 21:43 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2109092342110.59@tvgsbejvaqbjf.bet>
- In-Reply-To
- <a4212a67-ba79-0976-db19-334812137e81@gmail.com>
Hi Philippe,
On Thu, 9 Sep 2021, Philippe Blain wrote:
Show 13 quoted lines
> Le 2021-09-09 à 06:53, Johannes Schindelin a écrit : > > > > On Wed, 8 Sep 2021, Philippe Blain wrote: > > > > > Anyway, I'm not saying that we should not do what this patch is > > > proposing, but I think caveats such as that should be documented in the > > > commit message, and maybe an audit of other configs that might results > > > in behavioural differences should be done. > > > > Since this is already a bug in the `apply` backend, it would be even > > better to follow-up with a fix, hint, hint, nudge, nudge ;-) > > I'm not sure I understand what you are saying.
I am saying that indeed, you found what I consider a bug, but it is already present in the `apply` backend. And then I am hoping that you could find the time to fix it ;-)
> The fact that 'rebase' does not pay attention to 'submodule.recurse' is > not a bug in my opinion, it's just a limitation of the current code...
But the code that spawned `git checkout` _did_ pay attention to the `submodule.*` settings, no?
Ciao, Dscho
Show 6 quoted lines
> Or do you mean something else? > > Thanks, > Philippe. > >