Re: [PATCH 5/5] rebase: remove unused parameter
- From
- Phillip Wood <phillip.wood123@gmail.com>
- Date
- Sep 9, 2021, 14:04 UTC
- Message-ID
- <632884f6-ff63-23de-c043-0848939b4e15@gmail.com>
- In-Reply-To
- <nycvar.QRO.7.76.6.2109091254010.59@tvgsbejvaqbjf.bet>
Hi Dscho
On 09/09/2021 11:54, Johannes Schindelin wrote:
Show 11 quoted lines
> Hi Phillip, > > On Wed, 8 Sep 2021, Phillip Wood via GitGitGadget wrote: > >> From: Phillip Wood <phillip.wood@dunelm.org.uk> >> >> Now that we use reset_head() we don't need to pass orig_head around. > > Does this indicate a change in behavior? When we call `update_ref()` with > the original `HEAD`, we get some version of safety in that it will fail if > anything changed the ref in an unexpected way in the meantime.
Good point, it looks like that was overlooked when the am rebase starting using reset_head(). There are already too many arguments to reset_head(), I'll look at changing it (in a separate commit) to take a struct of options instead.
Best Wishes
Phillip
> Ciao, > Dscho >