Re: [PATCH] whats-cooking: fix a couple of typos

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 25, 2021, 11:16 UTC
Message-ID: <nycvar.QRO.7.76.6.2108251310430.55@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqzgt6oet6.fsf@gitster.g>

Hi Junio,

On Tue, 24 Aug 2021, Junio C Hamano wrote:

Show 18 quoted lines

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >     whats-cooking: fix a couple of typos
> >
> >     I noticed a couple of typos while reading the most recent "What's
> >     cooking" mail.
>
> Thanks.
>
> https://trends.google.com/trends/explore?q=codepath,code%20path
> makes it clear that "code path" is how the phrase is typically
> written, but we have 233 instances of 'codepath' in our tree vs only
> 39 of 'code path', according to "git grep" X-<.

Right. Where coding style is concerned, I prefer to go by what I find in Git's source code, if only to avoid disrupting readers unnecessarily.

However, when it comes to English grammar and customs, I am fully aware that many contributors aren't native speakers. Myself included. Therefore, I trust spell checkers more than our source code on those matters (except when it comes to those Git-isms like "submodule", "reftable", or "superproject").

If you feel strongly, please feel free to drop everything except the "submoudle" -> "submodule" fix.

Ciao, Dscho