threads / patch / 56364

patchwhats-cooking: fix a couple of typos

Subject: [PATCH] whats-cooking: fix a couple of typos

## tl;dr

3 messages between Aug 24, 2021 and Aug 25, 2021. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Johannes Schindelin via GitGitGadget· Aug 24, 2021, 13:06 UTC · lore
From: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
    whats-cooking: fix a couple of typos
    
    I noticed a couple of typos while reading the most recent "What's
    cooking" mail.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1075%2Fdscho%2Ftodo-tyops-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1075/dscho/todo-tyops-v1
Pull-Request: https://github.com/git/git/pull/1075
 whats-cooking.txt | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Show changes to whats-cooking.txt +4 −4
diff --git a/whats-cooking.txt b/whats-cooking.txt
index 09a9916d4c..5c34d18a57 100644
--- a/whats-cooking.txt
+++ b/whats-cooking.txt
@@ -321,7 +321,7 @@ Release tarballs are available at:
  Originally merged to 'next' on 2021-08-09
 
  Bugfix for common ancestor negotiation recently introduced in "git
- push" codepath.
+ push" code path.
 
  Will merge to 'master'.
 
@@ -570,7 +570,7 @@ Release tarballs are available at:
  - Merge branch 'ds/add-with-sparse-index' into ds/sparse-index-ignored-files
  (this branch uses ds/add-with-sparse-index.)
 
- In cone mode, the sparse-index codepath learned to remove ignored
+ In cone mode, the sparse-index code path learned to remove ignored
  files (like build artifacts) outside the sparse cone, allowing the
  entire directory outside the sparse cone to be removed, which is
  especially useful when the sparse patterns change.
@@ -659,7 +659,7 @@ Release tarballs are available at:
  - Merge branch 'ar/submodule-add-config' into ar/submodule-add
  (this branch uses ar/submodule-add-config.)
 
- More parts of "git submoudle add" has been rewritten in C.
+ More parts of "git submodule add" has been rewritten in C.
 
 
 * cb/makefile-apple-clang (2021-08-06) 3 commits
@@ -763,7 +763,7 @@ Release tarballs are available at:
  - midx: don't provide a total for QSORT() progress
  - commit-graph: fix bogus counter in "Scanning merged commits" progress line
 
- The code to show progress indicator in a few codepaths did not
+ The code to show progress indicator in a few code paths did not
  cover between 0-100%, which has been corrected.
 
  The middle one wants to be discarded.

base-commit: ded2f065b417326184f3c71d5d3e8c701ebe3252

-- 
gitgitgadget
Junio C Hamano· Aug 24, 2021, 18:52 UTC · re: Johannes Schindelin via GitGitGadget · lore

Re: [PATCH] whats-cooking: fix a couple of typos

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 8 quoted lines
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>     whats-cooking: fix a couple of typos
>     
>     I noticed a couple of typos while reading the most recent "What's
>     cooking" mail.
Thanks.

https://trends.google.com/trends/explore?q=codepath,code%20path makes it clear that "code path" is how the phrase is typically written, but we have 233 instances of 'codepath' in our tree vs only 39 of 'code path', according to "git grep" X-<.

Johannes Schindelin· Aug 25, 2021, 11:16 UTC · re: Junio C Hamano · lore

Re: [PATCH] whats-cooking: fix a couple of typos

Hi Junio,
On Tue, 24 Aug 2021, Junio C Hamano wrote:
Show 18 quoted lines
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >     whats-cooking: fix a couple of typos
> >
> >     I noticed a couple of typos while reading the most recent "What's
> >     cooking" mail.
>
> Thanks.
>
> https://trends.google.com/trends/explore?q=codepath,code%20path
> makes it clear that "code path" is how the phrase is typically
> written, but we have 233 instances of 'codepath' in our tree vs only
> 39 of 'code path', according to "git grep" X-<.

Right. Where coding style is concerned, I prefer to go by what I find in Git's source code, if only to avoid disrupting readers unnecessarily.

However, when it comes to English grammar and customs, I am fully aware that many contributors aren't native speakers. Myself included. Therefore, I trust spell checkers more than our source code on those matters (except when it comes to those Git-isms like "submodule", "reftable", or "superproject").

If you feel strongly, please feel free to drop everything except the "submoudle" -> "submodule" fix.

Ciao, Dscho

← back to recent threads