git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 0/6] Finish converting git bisect to C part 4

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 24, 2021, 14:00 UTC
Message-ID
<nycvar.QRO.7.76.6.2108241559350.55@tvgsbejvaqbjf.bet>
In-Reply-To
<20210820172148.2249-1-mirucam@gmail.com>
Hi Miriam,
On Fri, 20 Aug 2021, Miriam Rubio wrote:
Show 11 quoted lines
> These patches correspond to a fourth part of patch series
> of Outreachy project "Finish converting `git bisect` from shell to C"
> started by Pranit Bauva and Tanushree Tumane
> (https://public-inbox.org/git/pull.117.git.gitgitgadget@gmail.com) and
> continued by me.
>
> This fourth part is formed by reimplementations of some `git bisect`
> subcommands, addition of tests and removal of some temporary subcommands.
>
> These patch series emails were generated from:
> https://gitlab.com/mirucam/git/commits/git-bisect-work-part4-v5.

Apart from the stdout redirection in 5/6, the patches look really stable to me.

Thanks, Dscho

Show 45 quoted lines
>
> I would like to thank Johannes Schindelin, Bagas Sanjaya and
> Christian Couder for reviewing this patch series.
>
> Specific changes
> ----------------
> [1/6] t6030-bisect-porcelain: add tests to control bisect run exit cases
> * Add evaluation of error code 255 in test 'bisect run fails with exit
> code equals or greater than 128'.
> * Remove test with error code smaller than 0.
> ---
>
> [4/6] bisect--helper: reimplement `bisect_visualize()`shell function in C
> * Use strvec_push() instead of strvec_pushl().
> ---
>
> [5/6] bisect--helper: reimplement `bisect_run` shell function in C
> * Add error message.
> * Remove exit variable.
> * Write contents of bisect_state() in BISECT_RUN file and show to user.
> ---
>
> Miriam Rubio (3):
>   t6030-bisect-porcelain: add tests to control bisect run exit cases
>   t6030-bisect-porcelain: add test for bisect visualize
>   bisect--helper: retire `--bisect-next-check` subcommand
>
> Pranit Bauva (2):
>   run-command: make `exists_in_PATH()` non-static
>   bisect--helper: reimplement `bisect_visualize()`shell function in C
>
> Tanushree Tumane (1):
>   bisect--helper: reimplement `bisect_run` shell function in C
>
>  builtin/bisect--helper.c    | 157 ++++++++++++++++++++++++++++++++++--
>  git-bisect.sh               |  87 +-------------------
>  run-command.c               |   2 +-
>  run-command.h               |  12 +++
>  t/t6030-bisect-porcelain.sh |  18 +++++
>  5 files changed, 182 insertions(+), 94 deletions(-)
>
> --
> 2.29.2
>
>
Previous: Miriam Rubio
Message 10 of 10 in “Finish converting git bisect to C part 4”
  1. 0/6 Finish converting git bisect to C part 4Miriam Rubio, Aug 20, 2021
  2. 1/6 t6030-bisect-porcelain: add tests to control bisect run exit casesMiriam Rubio, Aug 20, 2021
  3. 2/6 t6030-bisect-porcelain: add test for bisect visualizeMiriam Rubio, Aug 20, 2021
  4. 3/6 run-command: make `exists_in_PATH()` non-staticMiriam Rubio, Aug 20, 2021
  5. 4/6 bisect--helper: reimplement `bisect_visualize()`shell function in CMiriam Rubio, Aug 20, 2021
  6. 5/6 bisect--helper: reimplement `bisect_run` shell function in CMiriam Rubio, Aug 20, 2021
  7. Johannes SchindelinAug 24, 2021
  8. Miriam R.Aug 26, 2021
  9. 6/6 bisect--helper: retire `--bisect-next-check` subcommandMiriam Rubio, Aug 20, 2021
  10. Johannes SchindelinAug 24, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.