git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 1/6] t6030-bisect-porcelain: add tests to control bisect run exit cases

From
Miriam Rubio <mirucam@gmail.com>
Date
Aug 20, 2021, 17:21 UTC
Message-ID
<20210820172148.2249-2-mirucam@gmail.com>
In-Reply-To
<20210820172148.2249-1-mirucam@gmail.com>

There is a gap on bisect run test coverage related with error exits. Add two tests to control these error cases.

Signed-off-by: Miriam Rubio <mirucam@gmail.com>
---
 t/t6030-bisect-porcelain.sh | 11 +++++++++++
 1 file changed, 11 insertions(+)
diff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh
index a1baf4e451..e61b8143fd 100755
--- a/t/t6030-bisect-porcelain.sh
+++ b/t/t6030-bisect-porcelain.sh
@@ -962,4 +962,15 @@ test_expect_success 'bisect handles annotated tags' '
 	grep "$bad is the first bad commit" output
 '
 
+test_expect_success 'bisect run fails with exit code equals or greater than 128' '
+	write_script test_script.sh <<-\EOF &&
+	exit 128 >/dev/null
+	EOF
+	test_must_fail git bisect run ./test_script.sh > my_bisect_log.txt &&
+	write_script test_script.sh <<-\EOF &&
+	exit 255 >/dev/null
+	EOF
+	test_must_fail git bisect run ./test_script.sh >> my_bisect_log.txt
+'
+
 test_done
-- 
2.29.2
Previous: Miriam RubioNext: Miriam Rubio
Message 2 of 10 in “Finish converting git bisect to C part 4”
  1. 0/6 Finish converting git bisect to C part 4Miriam Rubio, Aug 20, 2021
  2. 1/6 t6030-bisect-porcelain: add tests to control bisect run exit casesMiriam Rubio, Aug 20, 2021
  3. 2/6 t6030-bisect-porcelain: add test for bisect visualizeMiriam Rubio, Aug 20, 2021
  4. 3/6 run-command: make `exists_in_PATH()` non-staticMiriam Rubio, Aug 20, 2021
  5. 4/6 bisect--helper: reimplement `bisect_visualize()`shell function in CMiriam Rubio, Aug 20, 2021
  6. 5/6 bisect--helper: reimplement `bisect_run` shell function in CMiriam Rubio, Aug 20, 2021
  7. Johannes SchindelinAug 24, 2021
  8. Miriam R.Aug 26, 2021
  9. 6/6 bisect--helper: retire `--bisect-next-check` subcommandMiriam Rubio, Aug 20, 2021
  10. Johannes SchindelinAug 24, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.