git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/4] rebase -r: some merge related fixes

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 24, 2021, 13:33 UTC
Message-ID
<nycvar.QRO.7.76.6.2108241533270.55@tvgsbejvaqbjf.bet>
In-Reply-To
<pull.1015.v2.git.1629474038.gitgitgadget@gmail.com>
Hi Phillip,
On Fri, 20 Aug 2021, Phillip Wood via GitGitGadget wrote:
Show 42 quoted lines
> Thanks for the feedback on V1. I have added a sentence to the commit message
> of the third patch to make it clear that the fast-forward code is just
> moved, not changed
>
> Cover letter from V1: This is a collection of merge related fixes for rebase
> -r
>
>  * Make merge -c behave like reword.
>  * When fast-forwarding a merge don't leave .git/MERGE_MSG around (reported
>    by Gábor)
>  * Make merge -c work when with --strategy
>
> Phillip Wood (4):
>   rebase -r: make 'merge -c' behave like reword
>   rebase -i: Add another reword test
>   rebase -r: don't write .git/MERGE_MSG when fast-forwarding
>   rebase -r: fix merge -c with a merge strategy
>
>  sequencer.c                   | 106 ++++++++++++++++++----------------
>  t/lib-rebase.sh               |  56 ++++++++++++++++++
>  t/t3404-rebase-interactive.sh |  13 +++++
>  t/t3430-rebase-merges.sh      |  38 +++++++++---
>  4 files changed, 155 insertions(+), 58 deletions(-)
>
>
> base-commit: 66262451ec94d30ac4b80eb3123549cf7a788afd
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1015%2Fphillipwood%2Fwip%2Fsequencer-merge-c-v2
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1015/phillipwood/wip/sequencer-merge-c-v2
> Pull-Request: https://github.com/gitgitgadget/git/pull/1015
>
> Range-diff vs v1:
>
>  1:  b514dbdf928 = 1:  b514dbdf928 rebase -r: make 'merge -c' behave like reword
>  2:  511cf9204ad = 2:  511cf9204ad rebase -i: Add another reword test
>  3:  01d5ed4cba0 ! 3:  080e580e11c rebase -r: don't write .git/MERGE_MSG when fast-forwarding
>      @@ Commit message
>           is not removed and can end up seeding the message of a commit made
>           after the rebase has finished. Avoid writing .git/MERGE_MSG when we
>           are fast-forwarding by writing the file after the fast-forward
>      -    checks.
>      +    checks. Note that there are no changes to the fast-forward code, it is
>      +    simply moved.
The result still looks fine to me.

Thank you, Dscho

Show 8 quoted lines
>
>           Note that the way this change is implemented means we no longer write
>           the author script when fast-forwarding either. I believe this is safe
>  4:  f2a2e3531a1 = 4:  b6981ea5439 rebase -r: fix merge -c with a merge strategy
>
> --
> gitgitgadget
>
Previous: Phillip Wood via GitGitGadget
Message 15 of 15 in “rebase -r: some merge related fixes”
  1. 0/4 rebase -r: some merge related fixesPhillip Wood via GitGitGadget, Aug 13, 2021
  2. 1/4 rebase -r: make 'merge -c' behave like rewordPhillip Wood via GitGitGadget, Aug 13, 2021
  3. 2/4 rebase -i: Add another reword testPhillip Wood via GitGitGadget, Aug 13, 2021
  4. 3/4 rebase -r: don't write .git/MERGE_MSG when fast-forwardingPhillip Wood via GitGitGadget, Aug 13, 2021
  5. SZEDER GáborAug 17, 2021
  6. Phillip WoodAug 19, 2021
  7. 4/4 rebase -r: fix merge -c with a merge strategyPhillip Wood via GitGitGadget, Aug 13, 2021
  8. Johannes SchindelinAug 14, 2021
  9. Phillip WoodAug 19, 2021
  10. 0/4 rebase -r: some merge related fixesPhillip Wood via GitGitGadget, Aug 20, 2021
  11. 1/4 rebase -r: make 'merge -c' behave like rewordPhillip Wood via GitGitGadget, Aug 20, 2021
  12. 2/4 rebase -i: Add another reword testPhillip Wood via GitGitGadget, Aug 20, 2021
  13. 3/4 rebase -r: don't write .git/MERGE_MSG when fast-forwardingPhillip Wood via GitGitGadget, Aug 20, 2021
  14. 4/4 rebase -r: fix merge -c with a merge strategyPhillip Wood via GitGitGadget, Aug 20, 2021
  15. Johannes SchindelinAug 24, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.