git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/4] rebase -i: Add another reword test

From
PGPhillip Wood via GitGitGadget <gitgitgadget@gmail.com>
Date
Aug 13, 2021, 13:07 UTC
Message-ID
<511cf9204ad5a785ffb2e2eebc757a4e58579826.1628860053.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1015.git.1628860053.gitgitgadget@gmail.com>
From: Phillip Wood <phillip.wood@dunelm.org.uk>

None of the existing reword tests check that there are no uncommitted changes when the editor is opened. Reuse the editor script from the last commit to fix this omission.

Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
---
 t/t3404-rebase-interactive.sh | 13 +++++++++++++
 1 file changed, 13 insertions(+)
diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh
index 66bcbbf9528..d877872e8f4 100755
--- a/t/t3404-rebase-interactive.sh
+++ b/t/t3404-rebase-interactive.sh
@@ -839,6 +839,19 @@ test_expect_success 'reword' '
 	git show HEAD~2 | grep "C changed"
 '
 
+test_expect_success 'no uncommited changes when rewording the todo list is reloaded' '
+	git checkout E &&
+	test_when_finished "git checkout @{-1}" &&
+	(
+		set_fake_editor &&
+		GIT_SEQUENCE_EDITOR="\"$PWD/fake-editor.sh\"" &&
+		export GIT_SEQUENCE_EDITOR &&
+		set_reword_editor &&
+		FAKE_LINES="reword 1 reword 2" git rebase -i C
+	) &&
+	check_reworded_commits D E
+'
+
 test_expect_success 'rebase -i can copy notes' '
 	git config notes.rewrite.rebase true &&
 	git config notes.rewriteRef "refs/notes/*" &&
-- 
gitgitgadget
Previous: Phillip Wood via GitGitGadgetNext: Phillip Wood via GitGitGadget
Message 3 of 15 in “rebase -r: some merge related fixes”
  1. 0/4 rebase -r: some merge related fixesPhillip Wood via GitGitGadget, Aug 13, 2021
  2. 1/4 rebase -r: make 'merge -c' behave like rewordPhillip Wood via GitGitGadget, Aug 13, 2021
  3. 2/4 rebase -i: Add another reword testPhillip Wood via GitGitGadget, Aug 13, 2021
  4. 3/4 rebase -r: don't write .git/MERGE_MSG when fast-forwardingPhillip Wood via GitGitGadget, Aug 13, 2021
  5. SZEDER GáborAug 17, 2021
  6. Phillip WoodAug 19, 2021
  7. 4/4 rebase -r: fix merge -c with a merge strategyPhillip Wood via GitGitGadget, Aug 13, 2021
  8. Johannes SchindelinAug 14, 2021
  9. Phillip WoodAug 19, 2021
  10. 0/4 rebase -r: some merge related fixesPhillip Wood via GitGitGadget, Aug 20, 2021
  11. 1/4 rebase -r: make 'merge -c' behave like rewordPhillip Wood via GitGitGadget, Aug 20, 2021
  12. 2/4 rebase -i: Add another reword testPhillip Wood via GitGitGadget, Aug 20, 2021
  13. 3/4 rebase -r: don't write .git/MERGE_MSG when fast-forwardingPhillip Wood via GitGitGadget, Aug 20, 2021
  14. 4/4 rebase -r: fix merge -c with a merge strategyPhillip Wood via GitGitGadget, Aug 20, 2021
  15. Johannes SchindelinAug 24, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.