Re: [PATCH v3 6/7] ci(vs-build): build with NO_GETTEXT
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jul 14, 2021, 08:47 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2107141046130.76@tvgsbejvaqbjf.bet>
- In-Reply-To
- <xmqqsg0rjlm6.fsf@gitster.g>
Hi Junio,
On Tue, 6 Jul 2021, Junio C Hamano wrote:
Show 14 quoted lines
> "Dennis Ameling via GitGitGadget" <gitgitgadget@gmail.com> writes: > > > From: Dennis Ameling <dennis@dennisameling.com> > > > > We already build Git for Windows with `NO_GETTEXT` when compiling with > > GCC. Let's do the same with Visual C, too. > > > > Note that we do not technically _need_ to pass `NO_GETTEXT` explicitly > > in that `make artifacts-tar` invocation because we do this while `MSVC` > > is set (which will set `uname_S := Windows`, which in turn will set > > `NO_GETTEXT = YesPlease`). But it is definitely nicer to be explicit > > here. > > In other words, is this a no-op but makes the recipe more readable?
Yes. And it also removes some puzzlement from the thorough reviewer (Matthias stumbled over it and was wondering why this even works without `NO_GETTEXT`).
Thanks, Dscho