git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 5/6] ci(vs-build): build with NO_GETTEXT

From
DGDennis Ameling via GitGitGadget <gitgitgadget@gmail.com>
Date
Jun 23, 2021, 15:24 UTC
Message-ID
<a5084795ab039f6e7b9ab97cced3d7567e709327.1624461857.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.878.git.1624461857.gitgitgadget@gmail.com>
From: Dennis Ameling <dennis@dennisameling.com>

We already build Git for Windows with `NO_GETTEXT` when compiling with GCC. Let's do the same with Visual C, too.

Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 .github/workflows/main.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 0f7516c9ef..3b40c677ab 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -159,7 +159,7 @@ jobs:
       shell: bash
       run: |
         cmake `pwd`/contrib/buildsystems/ -DCMAKE_PREFIX_PATH=`pwd`/compat/vcbuild/vcpkg/installed/x64-windows \
-        -DMSGFMT_EXE=C:/git-sdk-64-minimal/mingw64/bin/msgfmt.exe -DPERL_TESTS=OFF -DPYTHON_TESTS=OFF -DCURL_NO_CURL_CMAKE=ON
+        -DNO_GETTEXT=YesPlease -DPERL_TESTS=OFF -DPYTHON_TESTS=OFF -DCURL_NO_CURL_CMAKE=ON
     - name: MSBuild
       run: msbuild git.sln -property:Configuration=Release -property:Platform=x64 -maxCpuCount:4 -property:PlatformToolset=v142
     - name: bundle artifact tar

-- 
gitgitgadget
Previous: Johannes Schindelin via GitGitGadgetNext: Ævar Arnfjörð Bjarmason
Message 4 of 41 in “ci: speed-up the Windows parts of our GitHub workflow”
  1. 0/6 ci: speed-up the Windows parts of our GitHub workflowJohannes Schindelin via GitGitGadget, Jun 23, 2021
  2. 2/6 ci (vs-build): use `cmd` to copy the DLLs, not `powershell`Johannes Schindelin via GitGitGadget, Jun 23, 2021
  3. 1/6 ci: use the new GitHub Action to download git-sdk-64-minimalJohannes Schindelin via GitGitGadget, Jun 23, 2021
  4. 5/6 ci(vs-build): build with NO_GETTEXTDennis Ameling via GitGitGadget, Jun 23, 2021
  5. Ævar Arnfjörð BjarmasonJul 4, 2021
  6. Ævar Arnfjörð BjarmasonJul 4, 2021
  7. Johannes SchindelinJul 13, 2021
  8. Philip OakleyJul 13, 2021
  9. Johannes SchindelinJul 14, 2021
  10. Ævar Arnfjörð BjarmasonJul 14, 2021
  11. 3/6 ci: upgrade to using actions/{up,down}load-artifacts v2Johannes Schindelin via GitGitGadget, Jun 23, 2021
  12. 4/6 ci(windows): transfer also the Git-tracked files to the test jobsJohannes Schindelin via GitGitGadget, Jun 23, 2021
  13. 6/6 ci: accelerate the checkoutJohannes Schindelin via GitGitGadget, Jun 23, 2021
  14. Junio C HamanoJul 1, 2021
  15. 0/7 ci: speed-up the Windows parts of our GitHub workflowJohannes Schindelin via GitGitGadget, Jul 3, 2021
  16. 2/7 ci (vs-build): use `cmd` to copy the DLLs, not `powershell`Johannes Schindelin via GitGitGadget, Jul 3, 2021
  17. 3/7 ci: upgrade to using actions/{up,down}load-artifacts v2Johannes Schindelin via GitGitGadget, Jul 3, 2021
  18. 1/7 ci: use the new GitHub Action to download git-sdk-64-minimalJohannes Schindelin via GitGitGadget, Jul 3, 2021
  19. 6/7 ci(vs-build): build with NO_GETTEXTDennis Ameling via GitGitGadget, Jul 3, 2021
  20. 5/7 artifacts-tar: respect NO_GETTEXTJohannes Schindelin via GitGitGadget, Jul 3, 2021
  21. Ævar Arnfjörð BjarmasonJul 4, 2021
  22. Johannes SchindelinJul 4, 2021
  23. Ævar Arnfjörð BjarmasonJul 5, 2021
  24. 7/7 ci: accelerate the checkoutJohannes Schindelin via GitGitGadget, Jul 3, 2021
  25. Ævar Arnfjörð BjarmasonJul 4, 2021
  26. Johannes SchindelinJul 4, 2021
  27. 4/7 ci(windows): transfer also the Git-tracked files to the test jobsJohannes Schindelin via GitGitGadget, Jul 3, 2021
  28. 0/7 ci: speed-up the Windows parts of our GitHub workflowJohannes Schindelin via GitGitGadget, Jul 4, 2021
  29. 1/7 ci: use the new GitHub Action to download git-sdk-64-minimalJohannes Schindelin via GitGitGadget, Jul 4, 2021
  30. Junio C HamanoJul 6, 2021
  31. 2/7 ci (vs-build): use `cmd` to copy the DLLs, not `powershell`Johannes Schindelin via GitGitGadget, Jul 4, 2021
  32. 3/7 ci: upgrade to using actions/{up,down}load-artifacts v2Johannes Schindelin via GitGitGadget, Jul 4, 2021
  33. 4/7 ci(windows): transfer also the Git-tracked files to the test jobsJohannes Schindelin via GitGitGadget, Jul 4, 2021
  34. 7/7 ci: accelerate the checkoutJohannes Schindelin via GitGitGadget, Jul 4, 2021
  35. 5/7 artifacts-tar: respect NO_GETTEXTJohannes Schindelin via GitGitGadget, Jul 4, 2021
  36. 6/7 ci(vs-build): build with NO_GETTEXTDennis Ameling via GitGitGadget, Jul 4, 2021
  37. Ævar Arnfjörð BjarmasonJul 5, 2021
  38. Johannes SchindelinJul 5, 2021
  39. Junio C HamanoJul 6, 2021
  40. Johannes SchindelinJul 14, 2021
  41. Junio C HamanoJul 6, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.