git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: ss/submodule-add-in-c, was Re: What's cooking in git.git (Dec 2020, #05; Mon, 28)

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 7, 2021, 23:23 UTC
Message-ID
<nycvar.QRO.7.76.6.2101080022310.2213@tvgsbejvaqbjf.bet>
In-Reply-To
<xmqqturvxa9t.fsf@gitster.c.googlers.com>
Hi Junio,
On Tue, 5 Jan 2021, Junio C Hamano wrote:
Show 21 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > On Mon, 28 Dec 2020, Junio C Hamano wrote:
> >
> >> * ss/submodule-add-in-c (2020-12-15) 3 commits
> >>  . t7400: add test to check 'submodule add' for tracked paths
> >>  . submodule: port submodule subcommand 'add' from shell to C
> >>  . dir: change the scope of function 'directory_exists_in_index()'
> >>
> >>  "git submodule add" being rewritten in C.
> >>
> >>  Expecting a reroll.
> >>  The patches are split incorrectly; part of 1/3 belongs to 2/3
> >>  cf. <nycvar.QRO.7.76.6.2012190104140.56@tvgsbejvaqbjf.bet>
> >>  It seems to introduce a segfault on 'seen'.
> >>  cf. <xmqqft3xflw7.fsf@gitster.c.googlers.com>
> >
> > Maybe nycvar.QRO.7.76.6.2012190104140.56@tvgsbejvaqbjf.bet would be a
> > better reference,...
>
> That is the first message-id referenced in the above, isn't it?

What I meant was to say that my message clarifies the segfault issue better than your reply...

Ciao, Dscho

Previous: Junio C Hamano
Message 7 of 7 in “What's cooking in git.git (Dec 2020, #05; Mon, 28)”
  1. Junio C HamanoDec 28, 2020
  2. Felipe ContrerasDec 29, 2020
  3. Junio C HamanoJan 6, 2021
  4. Christian CouderDec 29, 2020
  5. ss/submodule-add-in-c, was Re: What's cooking in git.git (Dec 2020, #05; Mon, 28)Johannes Schindelin, Jan 5, 2021
  6. Junio C HamanoJan 5, 2021
  7. Johannes SchindelinJan 7, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.