ss/submodule-add-in-c, was Re: What's cooking in git.git (Dec 2020, #05; Mon, 28)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 5, 2021, 15:41 UTC
Message-ID: <nycvar.QRO.7.76.6.2101051640150.2213@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqeej9g325.fsf@gitster.c.googlers.com>

Hi Junio,

On Mon, 28 Dec 2020, Junio C Hamano wrote:

Show 12 quoted lines

> * ss/submodule-add-in-c (2020-12-15) 3 commits
>  . t7400: add test to check 'submodule add' for tracked paths
>  . submodule: port submodule subcommand 'add' from shell to C
>  . dir: change the scope of function 'directory_exists_in_index()'
>
>  "git submodule add" being rewritten in C.
>
>  Expecting a reroll.
>  The patches are split incorrectly; part of 1/3 belongs to 2/3
>  cf. <nycvar.QRO.7.76.6.2012190104140.56@tvgsbejvaqbjf.bet>
>  It seems to introduce a segfault on 'seen'.
>  cf. <xmqqft3xflw7.fsf@gitster.c.googlers.com>

Maybe nycvar.QRO.7.76.6.2012190104140.56@tvgsbejvaqbjf.bet would be a better reference, as I diagnosed this issue and provided a patch that papers over the issue (hoping that the original contributor would not take it as-is).

Ciao, Dscho