Re: [PATCH v2 1/2] ci: skip GitHub workflow runs for already-tested commits/trees

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 12, 2020, 18:57 UTC
Message-ID: <nycvar.QRO.7.76.6.2010122044460.50@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqy2kbqv7b.fsf@gitster.c.googlers.com>

Hi Junio,

On Mon, 12 Oct 2020, Junio C Hamano wrote:

Show 10 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > Also, the patch specifically adjusts the GitHub workflow itself.
> > Therefore, unlike the `skip_good_tree()` function, it does not pretend to
> > be generic (which `skip_good_tree()` really is not, as pointed out above).
>
> I think skip_good_tree aspired to be a generic one, by having the
> "if we are not in travis nor GitHub actions, return early" at its
> very beginning. [...] it would have made the intention more clear if the
> conditional at the beginning of skip_good_tree() were adjusted, perhaps?

Full disclosure: I am not even sure what to do with Travis support at this stage (but then, I am not the one to decide over that).

In any case, it appears that no matter how generic the `skip_good_tree()` function meant to be, by virtue of using that `cache: directories:` feature (https://docs.travis-ci.com/user/caching) it is limited to Travis CI nevertheless.

So if we were to adjust the conditional at the beginning of `skip_good_tree()`, it would probably make sense to make it clear that this not only does not work with GitHub Actions, but in fact it does not work with anything but Travis.

Ciao, Dscho