Re: [PATCH v2 1/2] ci: skip GitHub workflow runs for already-tested commits/trees

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 11, 2020, 10:28 UTC
Message-ID: <nycvar.QRO.7.76.6.2010111221350.50@tvgsbejvaqbjf.bet>
In-Reply-To: <20201010072508.GD24813@szeder.dev>

Hi Gábor,

On Sat, 10 Oct 2020, SZEDER Gábor wrote:

Show 9 quoted lines

> On Fri, Oct 09, 2020 at 01:13:03PM +0200, Johannes Schindelin wrote:
>
> > Since this strategy relies on a Travis-only feature that does not work
> > on the three other CI services we use (Cirrus CI, Azure DevOps, GitHub
> > Actions), I see little point mentioning it in this commit message...
>
> This commit duplicates already existing functionality, so, yes, the
> commit message should definitely have explained why that already
> existing approach was not suitable for GitHub Actions.

No, this is not duplicating functionality.

The `skip_good_tree()` function requires a persistent directory into which it writes a record of the trees it considers good, based on past runs. It later recalls which trees are considers good and skips the current run if there is a record for this tree.

The fact that it requires a persistent directory binds it to Travis CI. As far as I can tell, no other CI service offers that feature (and from where I sit, for good reason, because it is asking for all kinds of fun in concurrent scenarios).

What my patch does might duplicate the intention, but absolutely not the functionality. For one, there is no extra record required. It uses the API to query the existing logs.

Also, the patch specifically adjusts the GitHub workflow itself. Therefore, unlike the `skip_good_tree()` function, it does not pretend to be generic (which `skip_good_tree()` really is not, as pointed out above).

Ciao, Dscho