Re: [PATCH 2/2] add--interactive.perl: specify --no-color explicitly

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 8, 2020, 18:51 UTC
Message-ID: <nycvar.QRO.7.76.6.2009082047220.54@tvgsbejvaqbjf.bet>
In-Reply-To: <20200907081739.GB1263923@coredump.intra.peff.net>

Hi Peff,

ACK on both patches, just one clarification:

On Mon, 7 Sep 2020, Jeff King wrote:

Show 6 quoted lines

> [...]
>
> One could argue that the test isn't very realistic; it's setting up this
> "pretend there's a pager" situation to get around the tty restrictions
> of the test environment. So one option would be to move back towards
> using a real tty. [...]

The main reason why we moved away from the "real" TTY is that the TTY we simulate in `t/test-terminal.perl` is not actually real at all on Windows. Instead, it is the Cygwin/MSYS2-emulated version of a PTY, and as a consequence `git.exe` simply has no way of accessing it.

Which means that by moving "back towards using a real tty" we would lose all test coverage on Windows, which is not a thought I like to entertain.

Ciao, Dscho