Re: [PATCH 2/2] add--interactive.perl: specify --no-color explicitly

From: Jeff King <peff@peff.net>
Date: Sep 9, 2020, 09:15 UTC
Message-ID: <20200909091520.GC2496536@coredump.intra.peff.net>
In-Reply-To: <nycvar.QRO.7.76.6.2009082047220.54@tvgsbejvaqbjf.bet>

On Tue, Sep 08, 2020 at 08:51:31PM +0200, Johannes Schindelin wrote:

Show 12 quoted lines

> > One could argue that the test isn't very realistic; it's setting up this
> > "pretend there's a pager" situation to get around the tty restrictions
> > of the test environment. So one option would be to move back towards
> > using a real tty. [...]
> 
> The main reason why we moved away from the "real" TTY is that the TTY we
> simulate in `t/test-terminal.perl` is not actually real at all on Windows.
> Instead, it is the Cygwin/MSYS2-emulated version of a PTY, and as a
> consequence `git.exe` simply has no way of accessing it.
> 
> Which means that by moving "back towards using a real tty" we would lose
> all test coverage on Windows, which is not a thought I like to entertain.

Yeah, regressing the improvements done by 8539b46534 (t3701: avoid depending on the TTY prerequisite, 2019-12-06) was definitely part of my motivation, but I guess I didn't spell that out completely.

-Peff