Re: [PATCH] setup: warn about un-enabled extensions
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jul 15, 2020, 19:21 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2007152117310.52@tvgsbejvaqbjf.bet>
- In-Reply-To
- <xmqqd04wk5kr.fsf@gitster.c.googlers.com>
Hi Junio,
On Wed, 15 Jul 2020, Junio C Hamano wrote:
Show 7 quoted lines
> Derrick Stolee <stolee@gmail.com> writes: > > > Of course, the _other_ option is to revert xl/upgrade-repo-format > > from v2.28.0 and take our time resolving this issue during the > > 2.29 cycle. I'm not sure how disruptive that action would be. > > Yes, that is becoming very much tempting at this point, isn't it?
It did cross my mind, too.
Show 5 quoted lines
> In any case, I've pushed out 'seen' with the "these extensions that > used to be honored in v0 won't interfere with repository upgrade" > patch I sent earlier, and I am hoping that it would be a reasonable > middle ground that won't regress things for users while making sure > we do not honor random future extensions by mistake.
Given that we still have -rc1 and -rc2 to make sure that things work, and given that your patch on top of Stolee's two patches looks like it is Doing The Best We Can Do, I am optimistic that your reasonable middle ground is the best way forward.
Thanks, Dscho