Re: [PATCH 1/3] t/lib-httpd: avoid using BSD's sed
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 27, 2020, 19:46 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2002272046060.46@tvgsbejvaqbjf.bet>
- In-Reply-To
- <CAPyFy2BZoJAuugAbmgsrbzjM1pNu7o9Wzusz1qV7No8Hr+T4ww@mail.gmail.com>
Hi Ed,
On Thu, 27 Feb 2020, Ed Maste wrote:
Show 14 quoted lines
> On Thu, 27 Feb 2020 at 10:40, Johannes Schindelin > <Johannes.Schindelin@gmx.de> wrote: > > > > My bad. I looked at StackOverflow and there the claim was that all BSD > > seds behave that way. > > > > Of course, SO always lags behind by a couple years (although even such old > > threads are often very useful), so it is possible that _old_ BSD sed > > behaved that way. > > Yeah, I wondered about the different behaviour, and asked on Twitter > about it. You're right, it is historical BSD behaviour and NetBSD at > least still appends the newline. FreeBSD changed this in 2014 - > http://bugs.freebsd.org/160745.
Thank you for digging into this!
Show 8 quoted lines
> > Related, I saw that Cirrus CI offers FreeBSD builds, maybe you'd be > > interested in supporting that out of the box in > > https://github.com/git/git? > > Indeed - there is a .cirrus.yml in git now which builds and runs tests > (on FreeBSD 12.1). I'll look into working with the GitHub organization > owners for git and gitgitgadget to see about allowing Cirrus to access > the repositories.
Oy, I had forgotten that you worked on this. I enabled this in the git and in the gitgitgadget orgs. The next pushes/PRs should benefit from this.
Thanks, Dscho