Re: [PATCH 1/3] t/lib-httpd: avoid using BSD's sed

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 27, 2020, 15:40 UTC
Message-ID: <nycvar.QRO.7.76.6.2002271640320.46@tvgsbejvaqbjf.bet>
In-Reply-To: <CAPyFy2ArnEFe33GFLsbcOEV37DZ=VJpF-Sckn-V_tJUrToir=w@mail.gmail.com>

Hi Ed,

On Wed, 26 Feb 2020, Ed Maste wrote:

Show 20 quoted lines

> On Wed, 26 Feb 2020 at 15:09, Johannes Schindelin via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
> >
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > Among other differences relative to GNU sed, BSD sed always ends its
> > output with a trailing newline, even if the input did not have such a
> > trailing newline.
> >
> > Surprisingly, this makes three httpd-based tests fail on macOS: t5616,
> > t5702 and t5703. ("Surprisingly" because those tests have been around
> > for some time, but apparently nobody runs them on macOS with a working
> > Apache2 setup.)
>
> Hmm, this is interesting - all tests (that are executed) are passing
> on FreeBSD, in CI.
>
> I tried on FreeBSD and do not see a trailing newline added; I'm not
> sure how sed behaves on other BSDs. However, you probably want to
> refer to macOS sed rather than BSD sed in the commit.

My bad. I looked at StackOverflow and there the claim was that all BSD seds behave that way.

Of course, SO always lags behind by a couple years (although even such old threads are often very useful), so it is possible that _old_ BSD sed behaved that way.

In any case, I adjusted the commit message.

Related, I saw that Cirrus CI offers FreeBSD builds, maybe you'd be interested in supporting that out of the box in https://github.com/git/git?

Ciao, Dscho