git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Patch text in git-add patch mode lacks whitespace highlighting

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Feb 1, 2020, 21:06 UTC
Message-ID
<nycvar.QRO.7.76.6.2002012205520.46@tvgsbejvaqbjf.bet>
In-Reply-To
<20200201110203.GA1864964@coredump.intra.peff.net>
Hi Peff,
On Sat, 1 Feb 2020, Jeff King wrote:
Show 11 quoted lines
> On Fri, Jan 31, 2020 at 01:37:44PM +0100, Johannes Schindelin wrote:
>
> > If my reading is correct, and we want `git diff-files --color` to respect
> > the `diff.wsErrorHighlight` setting, then this patch fixes that:
> > [...]
> > The bigger question is whether other core developers agree with this? And
> > what other `diff.*` settings should be respected by `git diff-files` (and
> > of course, `git diff-index`)?
>
> I think you can take my posting of an identical patch elsewhere in the
> thread as a "yes". :)
Thank you ;-)

That answer only applies to the first question, though. The second question, whether other `diff.*` settings would like to enjoy the same treatment, is still open for debate...

Thanks, Dscho

Previous: Jeff KingNext: Jeff King
Message 8 of 14 in “Patch text in git-add patch mode lacks whitespace highlighting”
  1. Mike McGranahanJan 30, 2020
  2. Jeff KingJan 31, 2020
  3. diff: move diff.wsErrorHighlight to "basic" configJeff King, Jan 31, 2020
  4. Mike McGranahanFeb 1, 2020
  5. Johannes SchindelinJan 31, 2020
  6. Mike McGranahanFeb 1, 2020
  7. Jeff KingFeb 1, 2020
  8. Johannes SchindelinFeb 1, 2020
  9. Jeff KingFeb 3, 2020
  10. Johannes SchindelinFeb 3, 2020
  11. Jeff KingFeb 3, 2020
  12. Junio C HamanoFeb 4, 2020
  13. Jeff KingFeb 4, 2020
  14. Johannes SchindelinFeb 4, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.