Re: Patch text in git-add patch mode lacks whitespace highlighting

From: Jeff King <peff@peff.net>
Date: Feb 3, 2020, 08:54 UTC
Message-ID: <20200203085456.GD2164@coredump.intra.peff.net>
In-Reply-To: <nycvar.QRO.7.76.6.2002012205520.46@tvgsbejvaqbjf.bet>

On Sat, Feb 01, 2020 at 10:06:43PM +0100, Johannes Schindelin wrote:

Show 15 quoted lines

> > > If my reading is correct, and we want `git diff-files --color` to respect
> > > the `diff.wsErrorHighlight` setting, then this patch fixes that:
> > > [...]
> > > The bigger question is whether other core developers agree with this? And
> > > what other `diff.*` settings should be respected by `git diff-files` (and
> > > of course, `git diff-index`)?
> >
> > I think you can take my posting of an identical patch elsewhere in the
> > thread as a "yes". :)
> 
> Thank you ;-)
> 
> That answer only applies to the first question, though. The second
> question, whether other `diff.*` settings would like to enjoy the same
> treatment, is still open for debate...

I hoped you would read the other part of the thread where I mused on that same question. :)

The short of my answer is that I think the color-moved stuff might be a candidate, but it's sufficiently different that I think it should be decided on as a separate patch.

-Peff