Re: Facing error in git-imap-send while compiling Git

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 17, 2020, 13:35 UTC
Message-ID: <nycvar.QRO.7.76.6.2001171433180.46@tvgsbejvaqbjf.bet>
In-Reply-To: <CAFFaXsz9LEdegzxL8MhS+VfTs-wmWu+CGDjxjB4Xgj8+7nSHNQ@mail.gmail.com>

Hi Nirmal,

On Fri, 17 Jan 2020, Nirmal Khedkar wrote:

Show 28 quoted lines

> On Fri, Jan 17, 2020 at 4:21 AM Junio C Hamano <gitster@pobox.com> wrote:
> >
> > Nirmal Khedkar <nirmalhk7@gmail.com> writes:
> >
> > > Hey!
> > > I've been facing this error everytime I run the Makefile:
> > > -----
> > > LINK git-imap-send
> > > imap-send.o: In function `verify_hostname':
> > > /git/imap-send.c:252: undefined reference to `sk_num'
> >
> > Perhaps the thread
> >
> >   https://lore.kernel.org/git/xmqqpnfv3tq4.fsf@gitster-ct.c.googlers.com
> >
> > may help?
>
> It did, to the extent that I now know why I'm facing these errors out
> of the blue.
>
> I'm  not quite sure as to what am I supposed to do right now, should I
> wait for Liam's patch to be merged,  or should I implement his fixes
> locally or should I just downgrade my openssl?
>
> Liam's PR (#516 on GitGitGadget [1]) haven't yet passed all build
> checks and I guess its still a work in progress. Nevertheless I've
> tried implementing his fixes to imap-send.c, and the make still fails.
> Am I missing something here?

Speaking for myself, I am still waiting for https://public-inbox.org/git/xmqqpnfv3tq4.fsf@gitster-ct.c.googlers.com/ to be addressed adequately. I think this is the main blocker.

You could be that person who addresses this, as already 10 days went past without even so much as an acknowledgement of Junio's suggestion. Maybe you can make it work, and submit a fixed patch (You could take authorship and add a footer "Original-patch-by: Liam Huang <liamhuang0205@gmail.com>" because it is most likely a total rewrite of Liam's patch).

Ciao, Johannes