Re: Facing error in git-imap-send while compiling Git

From: Nirmal Khedkar <nirmalhk7@gmail.com>
Date: Jan 20, 2020, 19:12 UTC
Message-ID: <CAFFaXsyiLeNPCZ+Kn1x-+0pZf0FiPQR-k8qtooFrdG+VNfLq+g@mail.gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.2001171433180.46@tvgsbejvaqbjf.bet>

Hey Johannes!

On Fri, Jan 17, 2020 at 7:05 PM Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 46 quoted lines

>
> Hi Nirmal,
>
> On Fri, 17 Jan 2020, Nirmal Khedkar wrote:
>
> > On Fri, Jan 17, 2020 at 4:21 AM Junio C Hamano <gitster@pobox.com> wrote:
> > >
> > > Nirmal Khedkar <nirmalhk7@gmail.com> writes:
> > >
> > > > Hey!
> > > > I've been facing this error everytime I run the Makefile:
> > > > -----
> > > > LINK git-imap-send
> > > > imap-send.o: In function `verify_hostname':
> > > > /git/imap-send.c:252: undefined reference to `sk_num'
> > >
> > > Perhaps the thread
> > >
> > >   https://lore.kernel.org/git/xmqqpnfv3tq4.fsf@gitster-ct.c.googlers.com
> > >
> > > may help?
> >
> > It did, to the extent that I now know why I'm facing these errors out
> > of the blue.
> >
> > I'm  not quite sure as to what am I supposed to do right now, should I
> > wait for Liam's patch to be merged,  or should I implement his fixes
> > locally or should I just downgrade my openssl?
> >
> > Liam's PR (#516 on GitGitGadget [1]) haven't yet passed all build
> > checks and I guess its still a work in progress. Nevertheless I've
> > tried implementing his fixes to imap-send.c, and the make still fails.
> > Am I missing something here?
>
> Speaking for myself, I am still waiting for
> https://public-inbox.org/git/xmqqpnfv3tq4.fsf@gitster-ct.c.googlers.com/
> to be addressed adequately. I think this is the main blocker.
>
> You could be that person who addresses this, as already 10 days went past
> without even so much as an acknowledgement of Junio's suggestion. Maybe
> you can make it work, and submit a fixed patch (You could take authorship
> and add a footer "Original-patch-by: Liam Huang <liamhuang0205@gmail.com>"
> because it is most likely a total rewrite of Liam's patch).
>
> Ciao,
> Johannes

The OpenSSL version on my system is 1.1.1. I've tried implementing Junio's suggestions, and it just doesn't work. It gives me the same error as it gave me earlier. Here's the error: ----- LINK git-imap-send imap-send.o: In function `verify_hostname': /git/imap-send.c:252: undefined reference to `sk_num' /git/imap-send.c:254: undefined reference to `sk_value' /git/imap-send.c:260: undefined reference to `sk_pop_free' /git/imap-send.c:260: undefined reference to `sk_pop_free' imap-send.o: In function `ssl_socket_connect': /git/imap-send.c:287: undefined reference to `SSL_library_init' /git/imap-send.c:288: undefined reference to `SSL_load_error_strings' /git/imap-send.c:290: undefined reference to `SSLv23_method' collect2: error: ld returned 1 exit status

Makefile:2454: recipe for target 'git-imap-send' failed make: *** [git-imap-send] Error 1 -----

From my limited understanding of OpenSSL API's, I reckon all these errors might be because of the errors around 'SSL_library_init' and 'SSL_load_error_strings'. Both these functions are called before 'verify_hostname' is ever called.

StackOverflow suggested ([1]) to add tags during compilation, but I dont think that'd work here. What should I do? Would love it if you could guide me out.

Thanks! Regards, Nirmal Khedkar https://nirmalhk7.github.io

[1] https://stackoverflow.com/questions/5593284/undefined-reference-to-ssl-library-init-and-ssl-load-error-strings