git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] dir: restructure in a way to avoid passing around a struct dirent

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 14, 2020, 21:07 UTC
Message-ID
<nycvar.QRO.7.76.6.2001142203450.46@tvgsbejvaqbjf.bet>
In-Reply-To
<pull.692.git.git.1579019532809.gitgitgadget@gmail.com>
Hi,
On Tue, 14 Jan 2020, Elijah Newren via GitGitGadget wrote:
> Restructure the code slightly to avoid passing around a struct dirent
> anywhere, which also enables us to avoid trying to manufacture one.

Please note that due a bug (which has been fixed in the meantime, see https://github.com/gitgitgadget/gitgitgadget/pull/188 for details), this GitGitGadget mail is missing the line

	From: Jeff King <peff@peff.net>
The patch itself looks fine to me.

Thanks, Dscho

Previous: Elijah Newren via GitGitGadgetNext: Elijah Newren
Message 2 of 15 in “dir: restructure in a way to avoid passing around a struct dirent”
  1. dir: restructure in a way to avoid passing around a struct direntElijah Newren via GitGitGadget, Jan 14, 2020
  2. Johannes SchindelinJan 14, 2020
  3. Elijah NewrenJan 14, 2020
  4. Jeff KingJan 14, 2020
  5. dir: restructure in a way to avoid passing around a struct direntElijah Newren via GitGitGadget, Jan 15, 2020
  6. dir: point treat_leading_path() warning to the right placeJeff King, Jan 15, 2020
  7. Elijah NewrenJan 15, 2020
  8. 0/4 dir: more fill_directory() fixesElijah Newren via GitGitGadget, Jan 16, 2020
  9. 2/4 dir: treat_leading_path() and read_directory_recursive(), round 2Elijah Newren via GitGitGadget, Jan 16, 2020
  10. Derrick StoleeJan 17, 2020
  11. 1/4 clean: demonstrate a bug with pathspecsDerrick Stolee via GitGitGadget, Jan 16, 2020
  12. Derrick StoleeJan 17, 2020
  13. Elijah NewrenJan 17, 2020
  14. 4/4 dir: point treat_leading_path() warning to the right placeJeff King via GitGitGadget, Jan 16, 2020
  15. 3/4 dir: restructure in a way to avoid passing around a struct direntJeff King via GitGitGadget, Jan 16, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.