git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] dir: restructure in a way to avoid passing around a struct dirent

From
Jeff King <peff@peff.net>
Date
Jan 14, 2020, 22:03 UTC
Message-ID
<20200114220357.GA3957260@coredump.intra.peff.net>
In-Reply-To
<pull.692.git.git.1579019532809.gitgitgadget@gmail.com>
On Tue, Jan 14, 2020 at 04:32:12PM +0000, Elijah Newren via GitGitGadget wrote:
Show 9 quoted lines
>     When I was more than a bit burned out on dir.c in late December, I had
>     looked at making another change to remove the need for a dirent but
>     punted because it looked like "way too much work". Junio and Peff both
>     later suggested the same cleanup, but I said it was too much work. Peff
>     posted a patch which demonstrated that it was actually pretty simple[1],
>     but I somehow read his email wrong and assumed he was commenting on my
>     patch (if I had looked even slightly closer...). His patch was actually
>     for before en/fill-directory-fixes was applied, so I have updated it
>     slightly to apply after that series.

Yeah, I hadn't really grokked your patch, so I was hoping you'd build your stuff on top. :)

Show 10 quoted lines
>     I'm not sure if I'm supposed to add a Reviewed-by me or a Signed-off-by
>     or both, but I read through it closely to avoid any hidden surprises. I
>     probably could have saved Dscho some time last month if I would have
>     just looked a little closer. Sorry about all that...
>     
>     (And yeah, we'll need Peff's Signed-off-by, since I'm leaving him as the
>     author; I really only made a small tweak to update his patch.)
>     
>     CC: Jeff King peff@peff.net [peff@peff.net], Johannes Schindelin 
>     Johannes.Schindelin@gmx.de [Johannes.Schindelin@gmx.de]

Hmm, looks like you maybe meant for more headers (and cc's) to happen than did. Anyway, I'm certainly fine with this direction, and you have my:

  Signed-off-by: Jeff King <peff@peff.net>
-Peff
Previous: Elijah NewrenNext: Elijah Newren via GitGitGadget
Message 4 of 15 in “dir: restructure in a way to avoid passing around a struct dirent”
  1. dir: restructure in a way to avoid passing around a struct direntElijah Newren via GitGitGadget, Jan 14, 2020
  2. Johannes SchindelinJan 14, 2020
  3. Elijah NewrenJan 14, 2020
  4. Jeff KingJan 14, 2020
  5. dir: restructure in a way to avoid passing around a struct direntElijah Newren via GitGitGadget, Jan 15, 2020
  6. dir: point treat_leading_path() warning to the right placeJeff King, Jan 15, 2020
  7. Elijah NewrenJan 15, 2020
  8. 0/4 dir: more fill_directory() fixesElijah Newren via GitGitGadget, Jan 16, 2020
  9. 2/4 dir: treat_leading_path() and read_directory_recursive(), round 2Elijah Newren via GitGitGadget, Jan 16, 2020
  10. Derrick StoleeJan 17, 2020
  11. 1/4 clean: demonstrate a bug with pathspecsDerrick Stolee via GitGitGadget, Jan 16, 2020
  12. Derrick StoleeJan 17, 2020
  13. Elijah NewrenJan 17, 2020
  14. 4/4 dir: point treat_leading_path() warning to the right placeJeff King via GitGitGadget, Jan 16, 2020
  15. 3/4 dir: restructure in a way to avoid passing around a struct direntJeff King via GitGitGadget, Jan 16, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.