Re: [PATCH] git-gui: allow closing console window with Escape
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Dec 13, 2019, 13:29 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1912131428490.46@tvgsbejvaqbjf.bet>
- In-Reply-To
- <20191210133105.apfim55w7osvskvh@yadavpratyush.com>
Hi,
On Tue, 10 Dec 2019, Pratyush Yadav wrote:
Show 16 quoted lines
> On 10/12/19 01:11PM, Vasili Novikov wrote: > > > Sorry if threading was broken: Thunderbird possibly doesn't fully support > > mbox import that I used. Or I did it unproperly. Either way, hope it's > > correct now. > > Threading seems to works fine for you. I meant avoiding top posting. > More explanation on top posting and bottom posting here > http://www.idallen.com/topposting.html > > > Thanks for explaining. I misunderstood the purpose of the window. If it's a > > slow ongoing task, then indeed it should not be closeable with Esc. I'd say > > it makes sense to allow Esc to work when it gets into "Success" state > > though, as in the screenshot. > > Hmm, I like the idea. Does that work for you Dscho?
I'm fine with whatever you settle with, I am not really a Git GUI user (I just deal with a couple of those users in my role as Git for Windows maintainer).
Ciao, Dscho