Re: [PATCH] git-gui: allow closing console window with Escape

From: Pratyush Yadav <me@yadavpratyush.com>
Date: Dec 8, 2019, 19:40 UTC
Message-ID: <20191208194046.csf35b7rgycst2vc@yadavpratyush.com>
In-Reply-To: <nycvar.QRO.7.76.6.1912071723010.31080@tvgsbejvaqbjf.bet>

On 07/12/19 05:24PM, Johannes Schindelin wrote:

Show 10 quoted lines

> Hi,
> 
> On Sat, 7 Dec 2019, Pratyush Yadav wrote:
> 
> > It is often expected that popup windows like the console window be
> > close-able with Esc.
> 
> Seeing as the console windows is not your regular popup window with an
> "OK" button, I could see how it would be all too easy to close the window
> via the Esc button all too easily, annoying users.

I'm not sure why it is "too easy" to hit Escape. If you're hitting Esc 
(which for most people is pretty far from other more frequently used 
keys) you expect _something_ to happen. People don't just spam Esc for 
no reason, do they?

> For windows like the console one, I would expect Ctrl+W a much more
> natural keyboard shortcut to close it.

But, that "something" the user expects to happen could also be "stop the command". AFAIK, Esc is often expected to stop commands. But closing the console window won't actually stop the command. It will keep running in the background, and when the command is done, the window will open again showing the final output.

So all in all, I do think Ctrl-W would be a better idea. Will re-roll.

> Ciao,
> Dscho

-- 
Regards,
Pratyush Yadav