Re: GitGitGadget on git/git, was Re: Should we auto-close PRs on git/git?

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 22, 2019, 13:50 UTC
Message-ID: <nycvar.QRO.7.76.6.1911221430510.31080@tvgsbejvaqbjf.bet>
In-Reply-To: <20191121105414.GA16238@sigill.intra.peff.net>

Hi Peff,

On Thu, 21 Nov 2019, Jeff King wrote:

Show 14 quoted lines

> On Mon, Nov 18, 2019 at 07:37:57PM +0100, Johannes Schindelin wrote:
>
> > Yeah, it wasn't easy. But then, who does not like a little challenge,
> > especially the challenge to test things outside of production? So here
> > is a PR: https://github.com/gitgitgadget/gitgitgadget/pull/148
> >
> > I trust everybody with even rudimentary Javascript skills to be able
> > to provide useful feedback on that PR.
>
> Wow, thanks for working on this! I don't know that I'd call my
> javascript skills even rudimentary, but I did give it a look. The real
> challenge to me is not the individual lines of code, but understanding
> how the Azure Pipelines and GitHub App systems fit together. So I didn't
> see anything wrong, but I also know very little about those systems.

I actually spent some quality time with the wiki in the past days to remedy that. You can adore the result in all its beauty here:

https://github.com/gitgitgadget/gitgitgadget/wiki/GitGitGadget's-Azure-Function-and-Azure-Pipelines

> Likewise, the explanations in your comments and commit messages all made
> sense to me. But that may also be a false sense of security. You nicely
> led me through reading the patches, but the likely bug would probably be
> one you did not even anticipate. ;)

Right, but it does help to have somebody cross-check the ideas.

You probably also realized that Chris Webster and Danh looked over them and provided useful suggestions, which I incorporated. One of those suggestions was to document the involved Azure Pipelines ;-)

Show 13 quoted lines

> > To build some confidence in my patches (as you probably know, I do not
> > trust reviews as much as I trust real-life testing, although I do
> > prefer to have both) I "kind of" activated it on my fork, limited to
> > act only on comments _I_ made on PRs (and sending only to me instead
> > of the list), and it seems to work all right, so far. I cannot say for
> > sure whether it handles the PR labels correctly, but I guess time will
> > tell, and I will fix bugs as quickly as I can.
>
> Yeah, that makes sense to me. Going from one repo to three is not much
> worse than going to two, so it's good to have a testing area, too.
>
> Do you want any third-party testing there (e.g., a user who isn't you
> making a PR against dscho/git)?

While that would be nice, my fork is a mess and not really set up to provide any useful target branch...

The real proof of the concept will come when the first git/git PR will be submitted.

Show 10 quoted lines

> > Question is: should I turn this thing on? I.e. install that
> > GitGitGadget-Git App on https://github.com/git/git? This would allow
> > GitHub users to `/submit` directly from PRs opened in that repository. I
> > am sure that there are a few kinks to work out, but I do think that it
> > should not take long to stabilize.
>
> I'd say "yes". The status quo is probably worse than a system with a few
> bugs. The worst case if it's disastrously wasting submitter's time is
> that we turn it back off, but I have faith that you'd just fix the bugs
> before then anyway.

Yes, I hope to be quick enough to fix things.

> Is the existing Pipelines integration enough for you to turn it on for
> git/git, or do I need to tweak any settings?

All I need is to install the app:

	Install GitGitGadget-Git

	Install on your organization Git @git
	All repositories

	This applies to all current and future repositories.
	Only select repositories
	Selected 1 repository.
	git/git

	...with these permissions:

	Read access to code
	Read access to checks and metadata
	Read and write access to issues and pull requests

... which I just did.

Thanks, Dscho