git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Should we auto-close PRs on git/git?

From
Jeff King <peff@peff.net>
Date
Nov 13, 2019, 01:10 UTC
Message-ID
<20191113011020.GB20431@sigill.intra.peff.net>
In-Reply-To
<nycvar.QRO.7.76.6.1911121946480.46@tvgsbejvaqbjf.bet>
On Tue, Nov 12, 2019 at 08:11:06PM +0100, Johannes Schindelin wrote:
Show 12 quoted lines
> > To that end, I wonder if we should add an Action to automatically
> > close PRs on that repo. It looks like
> > https://github.com/dessant/repo-lockdown would do the trick. We could
> > close incoming PRs automatically with a kind, maybe more succinct or
> > prescriptive version of the prefill text encouraging folks to open the
> > exact same PR against gitgitgadget/git instead.
> 
> I am rather certain that that would not be a good thing to do.
> 
> There are some people who open git/git PRs solely for the PR builds,
> others to facilitate code review, and yet others just because it is the
> intuitively obvious way to contribute to Git.

We talked a while ago about having GitGitGadget operate on git/git, rather than on a separate mirror. That would automatically help at least one class of PR-opener: people who want their patches to reach the list but didn't realize they should be using gitgitgadget/git.

I don't remember what the technical blockers are for getting that set up, but it seems like a strictly nicer outcome than auto-closing their PR.

-Peff
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 5 of 22 in “Should we auto-close PRs on git/git?”
  1. Emily ShafferNov 9, 2019
  2. Junio C HamanoNov 9, 2019
  3. Stephen SmithNov 13, 2019
  4. Johannes SchindelinNov 12, 2019
  5. Jeff KingNov 13, 2019
  6. Johannes SchindelinNov 13, 2019
  7. Jeff KingNov 14, 2019
  8. Johannes SchindelinNov 14, 2019
  9. GitGitGadget on git/git, was Re: Should we auto-close PRs on git/git?Johannes Schindelin, Nov 18, 2019
  10. Jeff KingNov 21, 2019
  11. Johannes SchindelinNov 22, 2019
  12. Johannes SchindelinNov 22, 2019
  13. Jeff KingNov 25, 2019
  14. Johannes SchindelinNov 26, 2019
  15. Eric WongNov 26, 2019
  16. Johannes SchindelinNov 26, 2019
  17. Eric WongNov 26, 2019
  18. Johannes SchindelinNov 26, 2019
  19. Eric WongNov 26, 2019
  20. Junio C HamanoNov 27, 2019
  21. Eric WongNov 27, 2019
  22. Emily ShafferNov 13, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.