Re: Should we auto-close PRs on git/git?
- From
Jeff King <peff@peff.net>
- Date
- Nov 13, 2019, 01:10 UTC
- Message-ID
- <20191113011020.GB20431@sigill.intra.peff.net>
- In-Reply-To
- <nycvar.QRO.7.76.6.1911121946480.46@tvgsbejvaqbjf.bet>
On Tue, Nov 12, 2019 at 08:11:06PM +0100, Johannes Schindelin wrote:
Show 12 quoted lines
> > To that end, I wonder if we should add an Action to automatically > > close PRs on that repo. It looks like > > https://github.com/dessant/repo-lockdown would do the trick. We could > > close incoming PRs automatically with a kind, maybe more succinct or > > prescriptive version of the prefill text encouraging folks to open the > > exact same PR against gitgitgadget/git instead. > > I am rather certain that that would not be a good thing to do. > > There are some people who open git/git PRs solely for the PR builds, > others to facilitate code review, and yet others just because it is the > intuitively obvious way to contribute to Git.
We talked a while ago about having GitGitGadget operate on git/git, rather than on a separate mirror. That would automatically help at least one class of PR-opener: people who want their patches to reach the list but didn't realize they should be using gitgitgadget/git.
I don't remember what the technical blockers are for getting that set up, but it seems like a strictly nicer outcome than auto-closing their PR.
-Peff