Re: [PATCH v2 1/1] clean: show an error message when the path is too long

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 19, 2019, 12:53 UTC
Message-ID: <nycvar.QRO.7.76.6.1907191452270.47@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqef2nz5xe.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Thu, 18 Jul 2019, Junio C Hamano wrote:

Show 10 quoted lines

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > Without an error message when `lstat()` failed, `git clean` would
> > abort without an error message, leaving the user quite puzzled.
>
> Let's drop the first three words ;-)  Sorry for not catching it
> earlier and parrotting the same mistake in my variant yesterday.

You mean the first four words.

Show 6 quoted lines

> > In particular on Windows, where the default maximum path length is quite
> > small (yet there are ways to circumvent that limit in many cases), it is
> > very important that users be given an indication why their command
> > failed because of too long paths when it did.
>
> s/it is very important that users be given/it helps to give users/

If you really feel it important to invalidate my personal style of expression, sure.

Ciao, Dscho