git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] Let rebase.reschedulefailedexec only affect interactive rebases

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 1, 2019, 11:52 UTC
Message-ID
<nycvar.QRO.7.76.6.1907011350210.44@tvgsbejvaqbjf.bet>
In-Reply-To
<70648c5b-00ff-d7aa-f1f7-8bb7bf663829@gmail.com>
Hi,
On Sun, 30 Jun 2019, Phillip Wood wrote:
Show 14 quoted lines
> On 28/06/2019 23:08, Junio C Hamano wrote:
> > Phillip Wood <phillip.wood123@gmail.com> writes:
> >
> > > One potential problem is if someone has an alias that always sets
> > > --reschedule-failed-exec but does not always add --exec to the
> > > command line.
> >
> > Such a use case would be hitting this die() already without this
> > topic, wouldn't it?  In which case we can say there is no "someone"
> > with such an alias.
>
> It depends what else the alias includes, if it also includes
> -i/-k/-r/--signoff then it wont have been dying but will if we start
> requiring --exec and they don't set that.

The entire reasoning behind the config variable was that it would allow changing the behavior just in case that the interactive rebase backend was in use.

In other words: I tried to introduce that config variable to prevent people from having afore-mentioned problems with the command-line option.

Therefore, from my perspective, it makes more sense to define such an alias using `-c ...` than using `--reschedule-failed-exec`, unless the alias is definitely only intended to launch interactive rebases.

Ciao, Dscho

Previous: Phillip WoodNext: Johannes Schindelin
Message 9 of 13 in “Make rebase.reschedulefailedexec less overzealous”
  1. 0/1 Make rebase.reschedulefailedexec less overzealousJohannes Schindelin via GitGitGadget, Jun 27, 2019
  2. 1/1 Let rebase.reschedulefailedexec only affect interactive rebasesJohannes Schindelin via GitGitGadget, Jun 27, 2019
  3. Junio C HamanoJun 27, 2019
  4. Johannes SchindelinJun 28, 2019
  5. Phillip WoodJun 28, 2019
  6. Junio C HamanoJun 28, 2019
  7. Vas SudanaguntaJun 28, 2019
  8. Phillip WoodJun 30, 2019
  9. Johannes SchindelinJul 1, 2019
  10. Johannes SchindelinJul 1, 2019
  11. 0/1 Make rebase.reschedulefailedexec less overzealousJohannes Schindelin via GitGitGadget, Jul 1, 2019
  12. 1/1 rebase --am: ignore rebase.reschedulefailedexecJohannes Schindelin via GitGitGadget, Jul 1, 2019
  13. Johannes SchindelinJul 1, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.