Re: [PATCH 6/6] Use the right 'struct repository' instead of the_repository

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 27, 2019, 09:06 UTC
Message-ID: <nycvar.QRO.7.76.6.1906271101140.44@tvgsbejvaqbjf.bet>
In-Reply-To: <20190624095533.22162-7-pclouds@gmail.com>

Hi Duy,

On Mon, 24 Jun 2019, Nguyễn Thái Ngọc Duy wrote:

> There are a couple of places where 'struct repository' is already passed
> around, but the_repository is still used. Use the right repo.

This patch series breaks t7814 on Linux, macOS and Windows, with GCC and clang (read: _every_ single job in the CI except for documentation and coccinelle).

For details, see https://dev.azure.com/gitgitgadget/git/_build/results?buildId=11536&view=ms.vss-test-web.build-test-results-tab

The first test case to break is t7814.9 basic grep tree:

-- snipsnap --
expecting success:
	cat >expect <<-\EOF &&
	HEAD:a:(1|2)d(3|4)
	HEAD:b/b:(3|4)
	HEAD:submodule/a:(1|2)d(3|4)
	HEAD:submodule/sub/a:(1|2)d(3|4)
	EOF

	git grep -e "(3|4)" --recurse-submodules HEAD >actual &&
	test_cmp expect actual

++ cat ++ git grep -e '(3|4)' --recurse-submodules HEAD fatal: unable to read tree (e6d32f554b2f8e48c3b8feece1653e933facb34a) error: last command exited with $?=128