Re: [PATCH 0/6] Kill the_repository in tree-walk.c

From: Derrick Stolee <stolee@gmail.com>
Date: Jun 27, 2019, 17:09 UTC
Message-ID: <7fbc8fc5-b834-c3f6-5d73-27caa55b01d9@gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.1906271458240.44@tvgsbejvaqbjf.bet>

On 6/27/2019 9:04 AM, Johannes Schindelin wrote:

> Given that this bug was only caught by a failing CI build, it does make me
> wonder what other bugs are hidden and would slip into our code base just
> because of gaps in the code coverage.

Here are the lines introduced by this series that are not covered by the test suite. I'm not asking you to write tests to cover these lines, but please re-examine the lines to be sure the correct conversion was made.

Thanks, -Stolee

Show 20 quoted lines

> Uncovered code in 'pu' not in 'jch'
> --------------------------------------------------------
> 
> archive.c
> 47f956bd 421) err = get_tree_entry(ar_args->repo,
> 47f956bd 422)      &tree->object.oid,
> 
> fast-import.c
> 35d7cdbe 2565) char *buf = read_object_with_reference(the_repository,
> 35d7cdbe 2566)        &n->oid,
> 
> match-trees.c
> 3fe87a7f 294) if (get_tree_entry(r, hash2, del_prefix, shifted, &mode))
> 
> t/helper/test-match-trees.c
> 3fe87a7f 23) shift_tree(the_repository, &one->object.oid, &two->object.oid, &shifted, -1);
>
> Nguyễn Thái Ngọc Duy	35d7cdbe sha1-file.c: remove the_repo from read_object_with_reference()
> Nguyễn Thái Ngọc Duy	3fe87a7f match-trees.c: remove the_repo from shift_tree*()
> Nguyễn Thái Ngọc Duy	47f956bd tree-walk.c: remove the_repo from get_tree_entry()