Re: [PATCH] doc: fix form -> from typo

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 25, 2019, 11:40 UTC
Message-ID: <nycvar.QRO.7.76.6.1906251339050.44@tvgsbejvaqbjf.bet>
In-Reply-To: <CAN0heSraZh+j04qjeaVtS5bsNoE=Hf_FBU-kfcB+69BkZz+zHg@mail.gmail.com>

Hi Martin,

On Tue, 25 Jun 2019, Martin Ågren wrote:

Show 12 quoted lines

> On Tue, 25 Jun 2019 at 09:43, Catalin Criste <cris_linu_w@yahoo.com> wrote:
>
> > @@ -88,7 +88,7 @@ save [-p|--patch] [-k|--[no-]keep-index] [-u|--include-untracked] [-a|--all] [-q
> >
> >         This option is deprecated in favour of 'git stash push'.  It
> >         differs from "stash push" in that it cannot take pathspecs,
> > -       and any non-option arguments form the message.
> > +       and any non-option arguments from the message.
>
> I think this is actually intended as "form". It took me a couple of
> readings, but what this paragraph wants to say is that any non-option
> arguments will be used to form (construct) the message.

You're right! I totally misread this, too.

> Do you have any suggestions as to how this could be made clearer?
> There are at least two of us that have stumbled on this. :-)

Make that three.

Maybe something like

	This option is deprecated in favour of 'git stash push'.  It
	differs from "stash push" in that it cannot take pathspecs;
	Instead, all non-option arguments are concatenated to form the stash
	message.

Ciao, Dscho