Re: [PATCH] doc: fix form -> from typo

From: Thomas Gummerer <t.gummerer@gmail.com>
Date: Jun 26, 2019, 08:22 UTC
Message-ID: <20190626082234.GC2423@hank.intra.tgummerer.com>
In-Reply-To: <CAN0heSraZh+j04qjeaVtS5bsNoE=Hf_FBU-kfcB+69BkZz+zHg@mail.gmail.com>

On 06/25, Martin Ågren wrote:

Show 19 quoted lines

> Hi Catalin
> 
> Welcome to the list!
> 
> On Tue, 25 Jun 2019 at 09:43, Catalin Criste <cris_linu_w@yahoo.com> wrote:
> 
> > @@ -88,7 +88,7 @@ save [-p|--patch] [-k|--[no-]keep-index] [-u|--include-untracked] [-a|--all] [-q
> >
> >         This option is deprecated in favour of 'git stash push'.  It
> >         differs from "stash push" in that it cannot take pathspecs,
> > -       and any non-option arguments form the message.
> > +       and any non-option arguments from the message.
> 
> I think this is actually intended as "form". It took me a couple of
> readings, but what this paragraph wants to say is that any non-option
> arguments will be used to form (construct) the message.
> 
> Do you have any suggestions as to how this could be made clearer?
> There are at least two of us that have stumbled on this. :-)

Even though I originally wrote this I had to have a double take on it. Maybe what you're saying above would be good? "and any non-option arguments are used to form the message" sounds a little clearer to me. Or maybe even use the word construct? Dunno.