git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 03/17] cache-tree.c: avoid reusing the DEBUG constant

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jun 19, 2019, 11:17 UTC
Message-ID
<nycvar.QRO.7.76.6.1906191316210.44@tvgsbejvaqbjf.bet>
In-Reply-To
<CAPUEspi-G7abt-zuLbw0iuyXN0gtrM_6Vy6d+9f-=6FpRsoV4A@mail.gmail.com>
Hi Carlo,
On Tue, 18 Jun 2019, Carlo Arenas wrote:
> shouldn't this also be a problem with builtin/blame.c?
Sharp eyes!

It does not *really* matter as much here, as that file defines that `DEBUG` constant if it has not yet been defined, but yes, it assumes that *if* it is defined, then it is set to `1`. Which is the case, but it is fragile.

I changed it locally already, and it will be part of the next iteration.

Thanks, Johannes

Previous: Carlo ArenasNext: Carlo Arenas
Message 9 of 83 in “Fix MSVC support, at long last”
  1. 00/17 Fix MSVC support, at long lastJohannes Schindelin via GitGitGadget, Jun 18, 2019
  2. 01/17 Mark .bat files as requiring CR/LF endingsJohannes Schindelin via GitGitGadget, Jun 18, 2019
  3. 05/17 mingw: replace mingw_startup() hackJohannes Schindelin via GitGitGadget, Jun 18, 2019
  4. 03/17 cache-tree.c: avoid reusing the DEBUG constantJeff Hostetler via GitGitGadget, Jun 18, 2019
  5. Eric SunshineJun 18, 2019
  6. Johannes SchindelinJun 19, 2019
  7. Junio C HamanoJun 19, 2019
  8. Carlo ArenasJun 19, 2019
  9. Johannes SchindelinJun 19, 2019
  10. Carlo ArenasJun 19, 2019
  11. Johannes SchindelinJun 19, 2019
  12. 02/17 t0001 (mingw): do not expect a specific order of stdout/stderrJohannes Schindelin via GitGitGadget, Jun 18, 2019
  13. Eric SunshineJun 18, 2019
  14. Johannes SixtJun 19, 2019
  15. Eric SunshineJun 19, 2019
  16. Johannes SchindelinJun 19, 2019
  17. Johannes SchindelinJun 19, 2019
  18. Johannes SixtJun 19, 2019
  19. Johannes SchindelinJun 19, 2019
  20. 09/17 msvc: mark a variable as non-constJeff Hostetler via GitGitGadget, Jun 18, 2019
  21. 10/17 msvc: do not re-declare the timespec structJeff Hostetler via GitGitGadget, Jun 18, 2019
  22. 06/17 msvc: fix dependencies of compat/msvc.cJohannes Schindelin via GitGitGadget, Jun 18, 2019
  23. 07/17 msvc: include sigset_t definitionPhilip Oakley via GitGitGadget, Jun 18, 2019
  24. 08/17 msvc: define O_ACCMODEPhilip Oakley via GitGitGadget, Jun 18, 2019
  25. 04/17 obstack: fix compiler warningJohannes Schindelin via GitGitGadget, Jun 18, 2019
  26. 15/17 msvc: do not pretend to support all signalsJeff Hostetler via GitGitGadget, Jun 18, 2019
  27. Eric SunshineJun 19, 2019
  28. Johannes SchindelinJun 19, 2019
  29. 16/17 msvc: avoid debug assertion windows in Debug ModeJohannes Schindelin via GitGitGadget, Jun 18, 2019
  30. 13/17 msvc: support building Git using MS Visual C++Jeff Hostetler via GitGitGadget, Jun 18, 2019
  31. Carlo ArenasJun 19, 2019
  32. Johannes SchindelinJun 19, 2019
  33. Eric SunshineJun 19, 2019
  34. Johannes SchindelinJun 19, 2019
  35. 14/17 msvc: add pragmas for common warningsPhilip Oakley via GitGitGadget, Jun 18, 2019
  36. 12/17 msvc: fix detect_msys_tty()Jeff Hostetler via GitGitGadget, Jun 18, 2019
  37. 17/17 msvc: ignore .dll and incremental compile outputJeff Hostetler via GitGitGadget, Jun 18, 2019
  38. 11/17 msvc: define ftello()Jeff Hostetler via GitGitGadget, Jun 18, 2019
  39. 00/20 Fix MSVC support, at long lastJohannes Schindelin via GitGitGadget, Jun 19, 2019
  40. 01/20 mingw: fix a typo in the msysGit-specific sectionJohannes Schindelin via GitGitGadget, Jun 19, 2019
  41. 02/20 Mark .bat files as requiring CR/LF endingsJohannes Schindelin via GitGitGadget, Jun 19, 2019
  42. 03/20 t0001 (mingw): do not expect a specific order of stdout/stderrJohannes Schindelin via GitGitGadget, Jun 19, 2019
  43. 07/20 msvc: fix dependencies of compat/msvc.cJohannes Schindelin via GitGitGadget, Jun 19, 2019
  44. 06/20 mingw: replace mingw_startup() hackJohannes Schindelin via GitGitGadget, Jun 19, 2019
  45. 05/20 obstack: fix compiler warningJohannes Schindelin via GitGitGadget, Jun 19, 2019
  46. 09/20 msvc: define O_ACCMODEPhilip Oakley via GitGitGadget, Jun 19, 2019
  47. 10/20 msvc: mark a variable as non-constJeff Hostetler via GitGitGadget, Jun 19, 2019
  48. 12/20 msvc: define ftello()Jeff Hostetler via GitGitGadget, Jun 19, 2019
  49. 16/20 msvc: add a compile-time flag to allow detailed heap debuggingJeff Hostetler via GitGitGadget, Jun 19, 2019
  50. 17/20 msvc: add pragmas for common warningsPhilip Oakley via GitGitGadget, Jun 19, 2019
  51. 15/20 msvc: support building Git using MS Visual C++Jeff Hostetler via GitGitGadget, Jun 19, 2019
  52. Johannes SchindelinJun 21, 2019
  53. Junio C HamanoJun 21, 2019
  54. 19/20 msvc: avoid debug assertion windows in Debug ModeJohannes Schindelin via GitGitGadget, Jun 19, 2019
  55. 20/20 msvc: ignore .dll and incremental compile outputJeff Hostetler via GitGitGadget, Jun 19, 2019
  56. 13/20 msvc: fix detect_msys_tty()Jeff Hostetler via GitGitGadget, Jun 19, 2019
  57. 18/20 msvc: do not pretend to support all signalsJeff Hostetler via GitGitGadget, Jun 19, 2019
  58. 14/20 msvc: update Makefile to allow for spaces in the compiler pathJeff Hostetler via GitGitGadget, Jun 19, 2019
  59. 04/20 cache-tree/blame: avoid reusing the DEBUG constantJeff Hostetler via GitGitGadget, Jun 19, 2019
  60. 11/20 msvc: do not re-declare the timespec structJeff Hostetler via GitGitGadget, Jun 19, 2019
  61. 08/20 msvc: include sigset_t definitionPhilip Oakley via GitGitGadget, Jun 19, 2019
  62. 00/20 Fix MSVC support, at long lastJohannes Schindelin via GitGitGadget, Jun 25, 2019
  63. 01/20 mingw: fix a typo in the msysGit-specific sectionJohannes Schindelin via GitGitGadget, Jun 25, 2019
  64. 02/20 Mark .bat files as requiring CR/LF endingsJohannes Schindelin via GitGitGadget, Jun 25, 2019
  65. 03/20 t0001 (mingw): do not expect a specific order of stdout/stderrJohannes Schindelin via GitGitGadget, Jun 25, 2019
  66. 04/20 cache-tree/blame: avoid reusing the DEBUG constantJeff Hostetler via GitGitGadget, Jun 25, 2019
  67. 07/20 msvc: fix dependencies of compat/msvc.cJohannes Schindelin via GitGitGadget, Jun 25, 2019
  68. 11/20 msvc: do not re-declare the timespec structJeff Hostetler via GitGitGadget, Jun 25, 2019
  69. 10/20 msvc: mark a variable as non-constJeff Hostetler via GitGitGadget, Jun 25, 2019
  70. 13/20 msvc: fix detect_msys_tty()Jeff Hostetler via GitGitGadget, Jun 25, 2019
  71. 16/20 msvc: add a compile-time flag to allow detailed heap debuggingJeff Hostetler via GitGitGadget, Jun 25, 2019
  72. 14/20 msvc: update Makefile to allow for spaces in the compiler pathJeff Hostetler via GitGitGadget, Jun 25, 2019
  73. 18/20 msvc: do not pretend to support all signalsJeff Hostetler via GitGitGadget, Jun 25, 2019
  74. 15/20 msvc: support building Git using MS Visual C++Jeff Hostetler via GitGitGadget, Jun 25, 2019
  75. 17/20 msvc: add pragmas for common warningsPhilip Oakley via GitGitGadget, Jun 25, 2019
  76. 19/20 msvc: avoid debug assertion windows in Debug ModeJohannes Schindelin via GitGitGadget, Jun 25, 2019
  77. 20/20 msvc: ignore .dll and incremental compile outputJeff Hostetler via GitGitGadget, Jun 25, 2019
  78. 12/20 msvc: define ftello()Jeff Hostetler via GitGitGadget, Jun 25, 2019
  79. 09/20 msvc: define O_ACCMODEPhilip Oakley via GitGitGadget, Jun 25, 2019
  80. 05/20 obstack: fix compiler warningJohannes Schindelin via GitGitGadget, Jun 25, 2019
  81. 08/20 msvc: include sigset_t definitionPhilip Oakley via GitGitGadget, Jun 25, 2019
  82. 06/20 mingw: replace mingw_startup() hackJohannes Schindelin via GitGitGadget, Jun 25, 2019
  83. Junio C HamanoJun 25, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.